Add ASSERT in ProcessData to warn of non-distinct buffers (GH #1088)

1 files changed, 8 insertions, 0 deletions

diff --git a/strciphr.cpp b/strciphr.cpp
index f73a05e1..d2e5feb3 100644
--- a/strciphr.cpp
+++ b/strciphr.cpp
@@ -81,6 +81,10 @@ void AdditiveCipherTemplate<S>::ProcessData(byte *outString, const byte *inStrin
 	CRYPTOPP_ASSERT(outString); CRYPTOPP_ASSERT(inString);

 	CRYPTOPP_ASSERT(length % this->MandatoryBlockSize() == 0);

 

+	// If this assert fires, then outString == inString. You could experience a

+	// performance hit. Also see https://github.com/weidai11/cryptopp/issues/1088'

+	CRYPTOPP_ASSERT(outString != inString);

+

 	PolicyInterface &policy = this->AccessPolicy();

 	unsigned int bytesPerIteration = policy.GetBytesPerIteration();

 

@@ -225,6 +229,10 @@ void CFB_CipherTemplate<BASE>::ProcessData(byte *outString, const byte *inString
 	CRYPTOPP_ASSERT(outString); CRYPTOPP_ASSERT(inString);

 	CRYPTOPP_ASSERT(length % this->MandatoryBlockSize() == 0);

 

+	// If this assert fires, then outString == inString. You could experience a

+	// performance hit. Also see https://github.com/weidai11/cryptopp/issues/1088'

+	CRYPTOPP_ASSERT(outString != inString);

+

 	PolicyInterface &policy = this->AccessPolicy();

 	unsigned int bytesPerIteration = policy.GetBytesPerIteration();

 	byte *reg = policy.GetRegisterBegin();