diff options
author | Simon McVittie <smcv@collabora.com> | 2018-08-17 15:42:17 +0100 |
---|---|---|
committer | Simon McVittie <smcv@collabora.com> | 2018-12-03 16:28:13 +0000 |
commit | 152b09ff5af506f2461902d3f1471a418c2f2e78 (patch) | |
tree | 7c667786b5765320516321c9b1e9a9f2bdee8981 /bus/activation.c | |
parent | 473f097471d5702663adb850be727bdeabab55a4 (diff) | |
download | dbus-152b09ff5af506f2461902d3f1471a418c2f2e78.tar.gz |
activation: Don't leak if delivering activation message is forbidden
This is technically a denial of service because the dbus-daemon will
run out of memory eventually, but it's a very slow and noisy one,
because all the rejected messages are also very likely to have
been logged to the system log.
Detected by AddressSanitizer.
Signed-off-by: Simon McVittie <smcv@collabora.com>
Resolves: https://gitlab.freedesktop.org/dbus/dbus/issues/234
Reviewed-by: pwithnall
Diffstat (limited to 'bus/activation.c')
-rw-r--r-- | bus/activation.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/bus/activation.c b/bus/activation.c index 706707ce..2c5d710f 100644 --- a/bus/activation.c +++ b/bus/activation.c @@ -1299,6 +1299,7 @@ bus_activation_send_pending_auto_activation_messages (BusActivation *activation entry->activation_message); } + dbus_error_free (&error); link = next; continue; } |