diff options
| author | Simon McVittie <smcv@collabora.com> | 2018-12-20 15:27:03 +0000 |
|---|---|---|
| committer | Ralf <ralf@linux1.fritz.box> | 2019-01-05 11:41:58 +0100 |
| commit | 88032367a960c96989a964006d28aa2f6851e4a8 (patch) | |
| tree | 54cd08a9dfa702711235e2124eda2b8b8eeba12d /bus | |
| parent | 5b72329d7d5947e0613a69a4b2d69975bd4a5b46 (diff) | |
| download | dbus-88032367a960c96989a964006d28aa2f6851e4a8.tar.gz | |
dbus-spawn: Don't take ownership of envp
It's unexpected for a function to take ownership of its arguments
without indicating that in its name, or at least documenting it.
The only caller with envp != NULL is in
bus_activation_activate_service(), which has been updated.
Based on part of a larger commit by Ralf Habacker.
Signed-off-by: Simon McVittie <smcv@collabora.com>
Diffstat (limited to 'bus')
| -rw-r--r-- | bus/activation.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/bus/activation.c b/bus/activation.c index 05dbfce4..30950636 100644 --- a/bus/activation.c +++ b/bus/activation.c @@ -2301,6 +2301,7 @@ bus_activation_activate_service (BusActivation *activation, } dbus_free_string_array (argv); + dbus_free_string_array (envp); envp = NULL; _dbus_assert (pending_activation->babysitter != NULL); |