diff options
| author | David Gibson <david@gibson.dropbear.id.au> | 2023-02-27 19:13:13 +1100 |
|---|---|---|
| committer | David Gibson <david@gibson.dropbear.id.au> | 2023-02-27 19:18:35 +1100 |
| commit | e3cde0613bfdd59d525770bc0e15c54e58b08412 (patch) | |
| tree | ba9aa3c6e5cde783d861d85ad14e73804e5d8eaa | |
| parent | 41821821101ad8a9f83746b96b163e5bcbdbe804 (diff) | |
| download | device-tree-compiler-e3cde0613bfdd59d525770bc0e15c54e58b08412.tar.gz | |
Add -Wsuggest-attribute=format warning, correct warnings thus generated
Add this new warning to the default build flags. It suggests adding
a ((format)) attribute to xavsprintf_append(), so do that.
Suggested-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
| -rw-r--r-- | Makefile | 3 | ||||
| -rw-r--r-- | meson.build | 3 | ||||
| -rw-r--r-- | util.h | 2 |
3 files changed, 5 insertions, 3 deletions
@@ -22,7 +22,8 @@ ASSUME_MASK ?= 0 CPPFLAGS = -I libfdt -I . -DFDT_ASSUME_MASK=$(ASSUME_MASK) WARNINGS = -Wall -Wpointer-arith -Wcast-qual -Wnested-externs -Wsign-compare \ - -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -Wshadow + -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -Wshadow \ + -Wsuggest-attribute=format CFLAGS = -g -Os $(SHAREDLIB_CFLAGS) -Werror $(WARNINGS) $(EXTRA_CFLAGS) BISON = bison diff --git a/meson.build b/meson.build index 78251eb..f50cf1e 100644 --- a/meson.build +++ b/meson.build @@ -14,7 +14,8 @@ add_project_arguments( '-Wstrict-prototypes', '-Wmissing-prototypes', '-Wredundant-decls', - '-Wshadow' + '-Wshadow', + '-Wsuggest-attribute=format', ]), language: 'c' ) @@ -65,7 +65,7 @@ extern char *xstrndup(const char *s, size_t len); extern int PRINTF(2, 3) xasprintf(char **strp, const char *fmt, ...); extern int PRINTF(2, 3) xasprintf_append(char **strp, const char *fmt, ...); -extern int xavsprintf_append(char **strp, const char *fmt, va_list ap); +extern int PRINTF(2, 0) xavsprintf_append(char **strp, const char *fmt, va_list ap); extern char *join_path(const char *path, const char *name); /** |