summaryrefslogtreecommitdiff
path: root/tests/fdtget-runtest.sh
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2012-02-03 16:12:08 +1100
committerJon Loeliger <jdl@jdl.com>2012-02-03 08:41:23 -0600
commitc34e88354a07099dbc15a41621c81f71325d25fd (patch)
tree25797eac796dd407a7660a14ab137c0b7c79c590 /tests/fdtget-runtest.sh
parent15b23d21a62b5a0295ee08b54d0842889ce94c92 (diff)
downloaddevice-tree-compiler-c34e88354a07099dbc15a41621c81f71325d25fd.tar.gz
Don't use diff to check fdt{get,put} results
Currently the fdt{get,put}-runtest.sh scripts invoke diff to check if fdt{get,put} did the right thing. This isn't great though: it's not obvious from the diff output which is the expected and which is the actual result; diff's line by line behaviour is useless here, since all the results are a single line and finally, when there is a difference it always prints information even when the tests are supposed to be running in quiet mode. This patch uses cmp instead, and explicitly prints the expected results, when running in verbose mode (the invocation of fdtget itself will have already displayed the actual results in this mode. Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'tests/fdtget-runtest.sh')
-rwxr-xr-xtests/fdtget-runtest.sh13
1 files changed, 7 insertions, 6 deletions
diff --git a/tests/fdtget-runtest.sh b/tests/fdtget-runtest.sh
index 75e7503..dac7f9a 100755
--- a/tests/fdtget-runtest.sh
+++ b/tests/fdtget-runtest.sh
@@ -13,11 +13,12 @@ shift
verbose_run_log_check "$LOG" $VALGRIND $DTGET "$@"
-diff $EXPECT $LOG
-ret="$?"
-
-if [ "$ret" -eq 0 ]; then
- PASS
+if cmp $EXPECT $LOG>/dev/null; then
+ PASS
else
- FAIL
+ if [ -z "$QUIET_TEST" ]; then
+ echo "EXPECTED :-:"
+ cat $EXPECT
+ fi
+ FAIL "Results differ from expected"
fi