| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Make sure to read localslots for running locally
Currently the --localslots are only read when distributing,
not when running locally. Make sure to always parse the hosts
configuration, for --localslots and --localslots_cpp settings.
* Use --localslots_cpp from $DISTCC_HOSTS for gcc -E
We want to use --localslots_cpp for running gcc -E, so
use a special exit code to signal this to the local run.
* Fix documentation, there's only 8 slots and not 16
|
| |
|
| |
Fixes issue 28
|
| |
|
|
|
|
|
|
| |
"all servers busy" dcc_lock_pause is hardcoded at 1 sec, could be tunable.
Makes the pause time tunable via a new env var DISTCC_PAUSE_TIME_MSEC.
The default remains set for 1 second.
|
| |
|
|
|
|
|
| |
tested and reviewed by cheepero@gmail.com, to address
<http://code.google.com/p/distcc/issues/detail?id=36>
"distcc-mon-gnome displays multiple rows for same host/slot".
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that I observed (once!) when compiling the Linux kernel in pump mode:
- Ensure that locks are acquired in the reverse order that they will
be released: acquire remote lock before local lock.
- Ensure that locks are released on all fallback paths.
- Rename dcc_pick_host_from_list() as dcc_pick_host_from_list_and_lock_it(),
so that its locking effect is clearer.
- Document the lock ordering invariants.
- Document the unlocking behaviour of dcc_compile_remote().
Reviewers: Craig Silverstein, Nils Klarlund
|
| |
|
|
|
|
|
|
| |
(typically the only change is in the FSF street address). Add Google
copyright line in some places it was missing. Add GPLv2 notice to
avahi patches.
OKed by fergus
|
| |
|
|
|
|
|
|
|
| |
Also, fix the emacs var-setting line: it was missing a semicolon
before, which means the entire line was being ignored.
No contentful change.
Reviewed by fergus@google.com
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
lines. Fixed up resulting mis-indented code I noticed (mostly in
files that used 8 space indents, or used 4-space and 8-space indents
in the same file (!)). Added the emacs tab-var setting for all files,
not just some of them.
I also added in copyright notices for files I noticed that didn't have
them. We'll want to do another pass-through to fix these up properly,
though.
I used the following perl snippet to check for mis-indented code after
converting tabs to whitespace:
$ for i in *.{c,h}; do echo $i; perl -nle 'if ($indent > 0) {$sp=" " x $indent; /^$sp[^ ]/ && print "$.: $_"; $indent=0;}; if (/^( *).*{/ ) {$indent=length($1);} else {$indent=0;}' $i; done | less
It had false positives, but hopefully didn't miss anything.
Reviewed by klarlund@google.com
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
affects the way emacs users will see these files, when visiting them
in emacs. In particular, tabs will show up as 4 spaces, which is
(clearly) the setting the original distcc author used when writing the
code.
We also set an emacs variable to never insert new tabs, but use spaces
instead. This will help stop the problem we have now with mixed tabs
and spaces. In a future cleanup, we may replace all tabs with 4
spaces, and make other whitespace improvements.
The final new variable set, is to set line-wrapping at 78 chars.
Personally, I would have made it more like 72, but some existing files
already had the 78 limit, so I just do that everywhere, to be
consistent.
Reviewed by fergus@google.com
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(1) Correct order of -Is in Makefile.
(2) remove unnessary PATH modification in configure.ac (this is fergus's
suggestion -- hopefully this will do, this replaces a circumvention mechanism I
had originally concocted.
(3) Fix place of the include of popt in CPPFLAGS.
(4) Convert quoted includes of config.h to angle bracket includes so that the
build version, not the source version, of this file is picked up.
The order of -Is in the build system is wrong: it contradicts the
VPATH mechanism.
This means that builds in a build directory different from that
of the source (distribution) directory will find wrong files even
after the hapless developer has issued only a 'configure' command
in the source directory (but not actually 'made' any thing
there). For in that case, the src/config.h will be generated in
the source directory and this will be the file picked in the
build directory even if that directory has it's own src/config.h.
This can lead to wrong builds and it can be hard to diagnose the
problem.
Currently, this what CPPFLAGS end up being (as found in the
generated Makefile):
CPPFLAGS = -DHAVE_CONFIG_H -D_GNU_SOURCE \
-I../distcc/popt -I../distcc/src \
${DIR_DEFS} \
-Isrc -Ilzo \
-I"$(srcdir)/src" -I"$(srcdir)/lzo" \
Here my source dir was ../distcc.
The presence of '-I../distcc/popt' in front of -Isrc is the exact
opposite of the semantics of VPATH mechanism, which looks for
files in the build directory, then in the source directory.
Also, note the remarks in:
http://www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Headers
(they do not quite correctly discuss the search path, btw).
TESTING: I verified that with a corrupted config.h file in the source directory,
building now succeeds.
Also: make distcheck (it fails the same place as before: this is corrected in
another change of mine --- I'll verify that with that change in place, this
change makes 'make distcheck' succeed.)
REVIEWERS: fergus@google.com, csilvers@google.com
|
|
|
level. I'm doing this in two stages, because I don't understand svn
enough to be confident to do it in one. This first stage just copies
all the files from distcc/FOO to FOO. Now there are two copies of
each file under distcc; the Makefile/etc uses the one in distcc and
ignores the one at the top level.
The next commit will delete everything under distcc, and rewrite the
Makefile/etc to use the top-level versions instead.
|
