summaryrefslogtreecommitdiff
path: root/client/network_inspect_test.go
diff options
context:
space:
mode:
authorSebastiaan van Stijn <github@gone.nl>2023-05-10 13:17:40 +0200
committerSebastiaan van Stijn <github@gone.nl>2023-05-10 22:13:38 +0200
commit66ff1e063eac6626658bafaa034a2ef9af9ad290 (patch)
tree5227ebde88a0dda06da4a2d5d1f66bd2612d274a /client/network_inspect_test.go
parent685b3d820a7f10d1d0b6e90a19f1ba0cf5c2caa2 (diff)
downloaddocker-66ff1e063eac6626658bafaa034a2ef9af9ad290.tar.gz
client: update error-assertions in tests
- use is.ErrorType - replace uses of client.IsErrNotFound for errdefs.IsNotFound, as the client no longer returns the old error-type. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Diffstat (limited to 'client/network_inspect_test.go')
-rw-r--r--client/network_inspect_test.go13
1 files changed, 7 insertions, 6 deletions
diff --git a/client/network_inspect_test.go b/client/network_inspect_test.go
index 2af672e400..2e831c96f7 100644
--- a/client/network_inspect_test.go
+++ b/client/network_inspect_test.go
@@ -14,6 +14,7 @@ import (
"github.com/docker/docker/api/types/network"
"github.com/docker/docker/errdefs"
"gotest.tools/v3/assert"
+ is "gotest.tools/v3/assert/cmp"
)
func TestNetworkInspect(t *testing.T) {
@@ -69,7 +70,7 @@ func TestNetworkInspect(t *testing.T) {
t.Run("empty ID", func(t *testing.T) {
// verify that the client does not create a request if the network-ID/name is empty.
_, err := client.NetworkInspect(context.Background(), "", types.NetworkInspectOptions{})
- assert.Check(t, IsErrNotFound(err))
+ assert.Check(t, is.ErrorType(err, errdefs.IsNotFound))
})
t.Run("no options", func(t *testing.T) {
r, err := client.NetworkInspect(context.Background(), "network_id", types.NetworkInspectOptions{})
@@ -87,17 +88,17 @@ func TestNetworkInspect(t *testing.T) {
})
t.Run("global scope", func(t *testing.T) {
_, err := client.NetworkInspect(context.Background(), "network_id", types.NetworkInspectOptions{Scope: "global"})
- assert.ErrorContains(t, err, "Error: No such network: network_id")
- assert.Check(t, IsErrNotFound(err))
+ assert.Check(t, is.ErrorContains(err, "Error: No such network: network_id"))
+ assert.Check(t, is.ErrorType(err, errdefs.IsNotFound))
})
t.Run("unknown network", func(t *testing.T) {
_, err := client.NetworkInspect(context.Background(), "unknown", types.NetworkInspectOptions{})
- assert.ErrorContains(t, err, "Error: No such network: unknown")
- assert.Check(t, IsErrNotFound(err))
+ assert.Check(t, is.ErrorContains(err, "Error: No such network: unknown"))
+ assert.Check(t, is.ErrorType(err, errdefs.IsNotFound))
})
t.Run("server error", func(t *testing.T) {
// Just testing that an internal server error is converted correctly by the client
_, err := client.NetworkInspect(context.Background(), "test-500-response", types.NetworkInspectOptions{})
- assert.Check(t, errdefs.IsSystem(err))
+ assert.Check(t, is.ErrorType(err, errdefs.IsSystem))
})
}