Merge pull request #36144 from emil2k/node-id-required

Produce errors when empty ids are passed into inspect calls. 

1 files changed, 13 insertions, 0 deletions

diff --git a/client/network_inspect_test.go b/client/network_inspect_test.go
index 95fcb0d646..7031611911 100644
--- a/client/network_inspect_test.go
+++ b/client/network_inspect_test.go
@@ -11,6 +11,7 @@ import (
 
 	"github.com/docker/docker/api/types"
 	"github.com/docker/docker/api/types/network"
+	"github.com/pkg/errors"
 	"github.com/stretchr/testify/assert"
 	"golang.org/x/net/context"
 )
@@ -34,6 +35,18 @@ func TestNetworkInspectNotFoundError(t *testing.T) {
 	assert.True(t, IsErrNotFound(err))
 }
 
+func TestNetworkInspectWithEmptyID(t *testing.T) {
+	client := &Client{
+		client: newMockClient(func(req *http.Request) (*http.Response, error) {
+			return nil, errors.New("should not make request")
+		}),
+	}
+	_, _, err := client.NetworkInspectWithRaw(context.Background(), "", types.NetworkInspectOptions{})
+	if !IsErrNotFound(err) {
+		t.Fatalf("Expected NotFoundError, got %v", err)
+	}
+}
+
 func TestNetworkInspect(t *testing.T) {
 	expectedURL := "/networks/network_id"
 	client := &Client{