Merge pull request #22777 from WeiZhang555/wait-restarting

Bug fix: `docker run -i --restart always` hangs

1 files changed, 10 insertions, 1 deletions

diff --git a/daemon/attach.go b/daemon/attach.go
index 06eb2be3d4..3d4a51eead 100644
--- a/daemon/attach.go
+++ b/daemon/attach.go
@@ -119,6 +119,15 @@ func (daemon *Daemon) containerAttach(c *container.Container, stdin io.ReadClose
 			}()
 			stdinPipe = r
 		}
+
+		waitChan := make(chan struct{})
+		if c.Config.StdinOnce && !c.Config.Tty {
+			go func() {
+				c.WaitStop(-1 * time.Second)
+				close(waitChan)
+			}()
+		}
+
 		err := <-c.Attach(stdinPipe, stdout, stderr, keys)
 		if err != nil {
 			if _, ok := err.(container.DetachError); ok {
@@ -131,7 +140,7 @@ func (daemon *Daemon) containerAttach(c *container.Container, stdin io.ReadClose
 		// If we are in stdinonce mode, wait for the process to end
 		// otherwise, simply return
 		if c.Config.StdinOnce && !c.Config.Tty {
-			c.WaitStop(-1 * time.Second)
+			<-waitChan
 		}
 	}
 	return nil