diff options
| author | Sebastiaan van Stijn <github@gone.nl> | 2022-01-21 19:55:49 +0100 |
|---|---|---|
| committer | Sebastiaan van Stijn <github@gone.nl> | 2022-02-18 16:58:19 +0100 |
| commit | cf31aa0fa0d1b058bd138569d29d570081481c91 (patch) | |
| tree | 47a7269276529d7e25d82ffe1127e8acaf7ea3cd /distribution | |
| parent | 54d35c071dd8b8e757c70870e1e3c4d63c957dc1 (diff) | |
| download | docker-cf31aa0fa0d1b058bd138569d29d570081481c91.tar.gz | |
distribution/xfer: fix some nits in tests
- use const instead of a variable
- remove unneeded type-conversion
- use keys in literals
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Diffstat (limited to 'distribution')
| -rw-r--r-- | distribution/xfer/transfer_test.go | 4 | ||||
| -rw-r--r-- | distribution/xfer/upload_test.go | 12 |
2 files changed, 8 insertions, 8 deletions
diff --git a/distribution/xfer/transfer_test.go b/distribution/xfer/transfer_test.go index f8f8e96fe0..dca5a815bc 100644 --- a/distribution/xfer/transfer_test.go +++ b/distribution/xfer/transfer_test.go @@ -68,7 +68,7 @@ func TestTransfer(t *testing.T) { } func TestConcurrencyLimit(t *testing.T) { - concurrencyLimit := 3 + const concurrencyLimit = 3 var runningJobs int32 makeXferFunc := func(id string) DoFunc { @@ -126,7 +126,7 @@ func TestConcurrencyLimit(t *testing.T) { } func TestInactiveJobs(t *testing.T) { - concurrencyLimit := 3 + const concurrencyLimit = 3 var runningJobs int32 testDone := make(chan struct{}) diff --git a/distribution/xfer/upload_test.go b/distribution/xfer/upload_test.go index 4507feac7b..9150a63d7a 100644 --- a/distribution/xfer/upload_test.go +++ b/distribution/xfer/upload_test.go @@ -69,12 +69,12 @@ func (u *mockUploadDescriptor) Upload(ctx context.Context, progressOutput progre func uploadDescriptors(currentUploads *int32) []UploadDescriptor { return []UploadDescriptor{ - &mockUploadDescriptor{currentUploads, layer.DiffID("sha256:cbbf2f9a99b47fc460d422812b6a5adff7dfee951d8fa2e4a98caa0382cfbdbf"), 0}, - &mockUploadDescriptor{currentUploads, layer.DiffID("sha256:1515325234325236634634608943609283523908626098235490238423902343"), 0}, - &mockUploadDescriptor{currentUploads, layer.DiffID("sha256:6929356290463485374960346430698374523437683470934634534953453453"), 0}, - &mockUploadDescriptor{currentUploads, layer.DiffID("sha256:cbbf2f9a99b47fc460d422812b6a5adff7dfee951d8fa2e4a98caa0382cfbdbf"), 0}, - &mockUploadDescriptor{currentUploads, layer.DiffID("sha256:8159352387436803946235346346368745389534789534897538734598734987"), 1}, - &mockUploadDescriptor{currentUploads, layer.DiffID("sha256:4637863963478346897346987346987346789346789364879364897364987346"), 0}, + &mockUploadDescriptor{currentUploads: currentUploads, diffID: "sha256:cbbf2f9a99b47fc460d422812b6a5adff7dfee951d8fa2e4a98caa0382cfbdbf"}, + &mockUploadDescriptor{currentUploads: currentUploads, diffID: "sha256:1515325234325236634634608943609283523908626098235490238423902343"}, + &mockUploadDescriptor{currentUploads: currentUploads, diffID: "sha256:6929356290463485374960346430698374523437683470934634534953453453"}, + &mockUploadDescriptor{currentUploads: currentUploads, diffID: "sha256:cbbf2f9a99b47fc460d422812b6a5adff7dfee951d8fa2e4a98caa0382cfbdbf"}, + &mockUploadDescriptor{currentUploads: currentUploads, diffID: "sha256:8159352387436803946235346346368745389534789534897538734598734987", simulateRetries: 1}, + &mockUploadDescriptor{currentUploads: currentUploads, diffID: "sha256:4637863963478346897346987346987346789346789364879364897364987346"}, } } |