summaryrefslogtreecommitdiff
path: root/integration-cli/docker_api_images_test.go
diff options
context:
space:
mode:
authorSebastiaan van Stijn <github@gone.nl>2019-09-11 20:59:48 +0200
committerSebastiaan van Stijn <github@gone.nl>2019-09-11 20:59:48 +0200
commit5adaf52953476bf0ff612c8d78500e35821035bb (patch)
tree6f85da9150d3884c84c519e7b564d2a54c2c27d5 /integration-cli/docker_api_images_test.go
parent871994ce2afebae6704e68d0e3cffefed1ff0769 (diff)
downloaddocker-5adaf52953476bf0ff612c8d78500e35821035bb.tar.gz
integration-cli: Skip TestAPIImagesSaveAndLoad on RS3 and older
I've seen this test fail a number of times recently on RS1 Looking at failures, the test is taking a long time ro run (491.77s, which is more than 8 minutes), so perhaps it's just too slow on RS1, which may be because we switch to a different base image, or because we're now running on different machines. Compared to RS5 (still slow, but a lot faster); ``` --- PASS: Test/DockerSuite/TestAPIImagesSaveAndLoad (146.25s) ``` ``` --- FAIL: Test/DockerSuite/TestAPIImagesSaveAndLoad (491.77s) cli.go:45: assertion failed: Command: d:\CI-5\CI-93d2cf881\binary\docker.exe inspect --format {{.Id}} sha256:69e7c1ff23be5648c494294a3808c0ea3f78616fad67bfe3b10d3a7e2be5ff02 ExitCode: 1 Error: exit status 1 Stdout: Stderr: Error: No such object: sha256:69e7c1ff23be5648c494294a3808c0ea3f78616fad67bfe3b10d3a7e2be5ff02 Failures: ExitCode was 1 expected 0 Expected no error ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Diffstat (limited to 'integration-cli/docker_api_images_test.go')
-rw-r--r--integration-cli/docker_api_images_test.go4
1 files changed, 2 insertions, 2 deletions
diff --git a/integration-cli/docker_api_images_test.go b/integration-cli/docker_api_images_test.go
index 733c5c29be..c36fcf0c5b 100644
--- a/integration-cli/docker_api_images_test.go
+++ b/integration-cli/docker_api_images_test.go
@@ -62,8 +62,8 @@ func (s *DockerSuite) TestAPIImagesSaveAndLoad(c *testing.T) {
v, err := kernel.GetKernelVersion()
assert.NilError(c, err)
build, _ := strconv.Atoi(strings.Split(strings.SplitN(v.String(), " ", 3)[2][1:], ".")[0])
- if build == 16299 {
- c.Skip("Temporarily disabled on RS3 builds")
+ if build <= 16299 {
+ c.Skip("Temporarily disabled on RS3 and older because they are too slow. See #39909")
}
}