diff options
author | Vincent Demeester <vincent@sbr.pm> | 2017-01-16 11:30:14 +0100 |
---|---|---|
committer | Vincent Demeester <vincent@sbr.pm> | 2017-01-17 15:42:38 +0100 |
commit | c10f6ef43f884306eb3ef60b2d19fdc931cf34cc (patch) | |
tree | 8b704bc6cc71c2cff7b5db38fd7172bcb2581112 /integration-cli/docker_cli_save_load_test.go | |
parent | 8c7651998fcb41a73480f90aebe3ffadcb020d02 (diff) | |
download | docker-c10f6ef43f884306eb3ef60b2d19fdc931cf34cc.tar.gz |
Clean more build utils in integration cli
- Remove deprecated buildImage* functions
- Rename buildImageNew to buildImage
- Use *check.C in fakeContext* setup and in getIdByName
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Diffstat (limited to 'integration-cli/docker_cli_save_load_test.go')
-rw-r--r-- | integration-cli/docker_cli_save_load_test.go | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/integration-cli/docker_cli_save_load_test.go b/integration-cli/docker_cli_save_load_test.go index 73e19558a2..d64a0964df 100644 --- a/integration-cli/docker_cli_save_load_test.go +++ b/integration-cli/docker_cli_save_load_test.go @@ -260,12 +260,9 @@ func (s *DockerSuite) TestSaveDirectoryPermissions(c *check.C) { os.Mkdir(extractionDirectory, 0777) defer os.RemoveAll(tmpDir) - _, err = buildImage(name, - `FROM busybox + buildImageSuccessfully(c, name, withDockerfile(`FROM busybox RUN adduser -D user && mkdir -p /opt/a/b && chown -R user:user /opt/a - RUN touch /opt/a/b/c && chown user:user /opt/a/b/c`, - true) - c.Assert(err, checker.IsNil, check.Commentf("%v", err)) + RUN touch /opt/a/b/c && chown user:user /opt/a/b/c`)) out, _, err := testutil.RunCommandPipelineWithOutput( exec.Command(dockerBinary, "save", name), @@ -358,9 +355,7 @@ func (s *DockerSuite) TestSaveLoadNoTag(c *check.C) { name := "saveloadnotag" - _, err := buildImage(name, "FROM busybox\nENV foo=bar", true) - c.Assert(err, checker.IsNil, check.Commentf("%v", err)) - + buildImageSuccessfully(c, name, withDockerfile("FROM busybox\nENV foo=bar")) id := inspectField(c, name, "Id") // Test to make sure that save w/o name just shows imageID during load |