diff options
author | Sebastiaan van Stijn <github@gone.nl> | 2022-11-01 10:38:14 +0100 |
---|---|---|
committer | Sebastiaan van Stijn <github@gone.nl> | 2022-12-21 11:09:01 +0100 |
commit | ebda2fa2b5ad79d83684235d21defe12129595ea (patch) | |
tree | e5e7505979e1adc4107410a2e21f63602abf7e63 /integration/internal | |
parent | 39f59c32892a0461636b200a720f710cd2b2d9f4 (diff) | |
download | docker-ebda2fa2b5ad79d83684235d21defe12129595ea.tar.gz |
integration/internal: use strings.Cut() and minor refactor
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Diffstat (limited to 'integration/internal')
-rw-r--r-- | integration/internal/container/ops.go | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/integration/internal/container/ops.go b/integration/internal/container/ops.go index f3101a816c..18c93ea0ab 100644 --- a/integration/internal/container/ops.go +++ b/integration/internal/container/ops.go @@ -1,7 +1,6 @@ package container import ( - "fmt" "strings" containertypes "github.com/docker/docker/api/types/container" @@ -91,23 +90,20 @@ func WithVolume(target string) func(*TestContainerConfig) { // WithBind sets the bind mount of the container func WithBind(src, target string) func(*TestContainerConfig) { return func(c *TestContainerConfig) { - c.HostConfig.Binds = append(c.HostConfig.Binds, fmt.Sprintf("%s:%s", src, target)) + c.HostConfig.Binds = append(c.HostConfig.Binds, src+":"+target) } } -// WithTmpfs sets a target path in the container to a tmpfs -func WithTmpfs(target string) func(config *TestContainerConfig) { +// WithTmpfs sets a target path in the container to a tmpfs, with optional options +// (separated with a colon). +func WithTmpfs(targetAndOpts string) func(config *TestContainerConfig) { return func(c *TestContainerConfig) { if c.HostConfig.Tmpfs == nil { c.HostConfig.Tmpfs = make(map[string]string) } - spec := strings.SplitN(target, ":", 2) - var opts string - if len(spec) > 1 { - opts = spec[1] - } - c.HostConfig.Tmpfs[spec[0]] = opts + target, opts, _ := strings.Cut(targetAndOpts, ":") + c.HostConfig.Tmpfs[target] = opts } } |