diff options
author | Matt Johnston <matt@ucc.asn.au> | 2006-07-07 07:00:10 +0000 |
---|---|---|
committer | Matt Johnston <matt@ucc.asn.au> | 2006-07-07 07:00:10 +0000 |
commit | 973f09885b6616e30ce1080e44bd79186e5bb35b (patch) | |
tree | 2a534c409d94ac156ff6cdf8862b8dbff82f9e4e /cli-authinteract.c | |
parent | ec920bf4eab9ce3b234e95b0b981d17263a94d21 (diff) | |
download | dropbear-973f09885b6616e30ce1080e44bd79186e5bb35b.tar.gz |
BUG: The strings 'name' and 'instruction' are always allocated
but are only freed if the length of the string is greater then
zero. They should always be freed.
FIX: take the m_free(<string>) out of the conditional
From Erik Hovland
Diffstat (limited to 'cli-authinteract.c')
-rw-r--r-- | cli-authinteract.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/cli-authinteract.c b/cli-authinteract.c index 5a169cb..5fe5bf1 100644 --- a/cli-authinteract.c +++ b/cli-authinteract.c @@ -99,13 +99,14 @@ void recv_msg_userauth_info_request() { if (strlen(name) > 0) { cleantext(name); fprintf(stderr, "%s", name); - m_free(name); } + m_free(name); + if (strlen(instruction) > 0) { cleantext(instruction); fprintf(stderr, "%s", instruction); - m_free(instruction); } + m_free(instruction); for (i = 0; i < num_prompts; i++) { unsigned int response_len = 0; |