diff options
| author | Simon Glass <sjg@chromium.org> | 2013-01-27 11:13:11 -0800 |
|---|---|---|
| committer | Jon Loeliger <jdl@jdl.com> | 2013-01-27 14:18:35 -0600 |
| commit | 8055d77a5be3a4204b3aa5cd73ce5cc03362e193 (patch) | |
| tree | d416f42f2f8c050dff8e50d1c47562014e5a0bb2 | |
| parent | 1760e7ca03894689118646e229ca9487158cd0e8 (diff) | |
| download | dtc-8055d77a5be3a4204b3aa5cd73ce5cc03362e193.tar.gz | |
Adjust util_is_printable_string() comment and fix test
This commit which changed the behaviour of this function broke one
of the tests. Also the comment should be updated to reflect its new
behaviour.
Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
| -rwxr-xr-x | tests/run_tests.sh | 3 | ||||
| -rw-r--r-- | util.h | 8 |
2 files changed, 7 insertions, 4 deletions
diff --git a/tests/run_tests.sh b/tests/run_tests.sh index dd7f217..b56b626 100755 --- a/tests/run_tests.sh +++ b/tests/run_tests.sh @@ -498,9 +498,10 @@ fdtget_tests () { # run_fdtget_test <expected-result> [<flags>] <file> <node> <property> run_fdtget_test "MyBoardName" $dtb / model + run_fdtget_test "MyBoardName MyBoardFamilyName" $dtb / compatible run_fdtget_test "77 121 66 111 \ 97 114 100 78 97 109 101 0 77 121 66 111 97 114 100 70 97 109 105 \ -108 121 78 97 109 101 0" $dtb / compatible +108 121 78 97 109 101 0" -t bu $dtb / compatible run_fdtget_test "MyBoardName MyBoardFamilyName" -t s $dtb / compatible run_fdtget_test 32768 $dtb /cpus/PowerPC,970@1 d-cache-size run_fdtget_test 8000 -tx $dtb /cpus/PowerPC,970@1 d-cache-size @@ -57,12 +57,14 @@ extern char *xstrdup(const char *s); extern char *join_path(const char *path, const char *name); /** - * Check a string of a given length to see if it is all printable and - * has a valid terminator. + * Check a property of a given length to see if it is all printable and + * has a valid terminator. The property can contain either a single string, + * or multiple strings each of non-zero length. * * @param data The string to check * @param len The string length including terminator - * @return 1 if a valid printable string, 0 if not */ + * @return 1 if a valid printable string, 0 if not + */ int util_is_printable_string(const void *data, int len); /* |