diff options
author | Stephen Warren <swarren@nvidia.com> | 2013-05-31 12:33:04 -0600 |
---|---|---|
committer | Jon Loeliger <jdl@jdl.com> | 2013-06-03 08:28:58 -0500 |
commit | a1ee6f068e1c8dbc62873645037a353d7852d5cc (patch) | |
tree | 50f77874ae68ca8f957321966fbfc85b8487cb65 /convert-dtsv0-lexer.l | |
parent | 2e3fc7e9b3a4722a5500afaa9faf7874c61b2e6a (diff) | |
download | dtc-a1ee6f068e1c8dbc62873645037a353d7852d5cc.tar.gz |
dtc: ensure #line directives don't consume data from the next line
Previously, the #line parsing regex ended with ({WS}+[0-9]+)?. The {WS}
could match line-break characters. If the #line directive did not contain
the optional flags field at the end, this could cause any integer data on
the next line to be consumed as part of the #line directive parsing. This
could cause syntax errors (i.e. #line parsing consuming the leading 0
from a hex literal 0x1234, leaving x1234 to be parsed as cell data,
which is a syntax error), or invalid compilation results (i.e. simply
consuming literal 1234 as part of the #line processing, thus removing it
from the cell data).
Fix this by replacing {WS} with [ \t] so that it can't match line-breaks.
Convert all instances of {WS}, even though the other instances should be
irrelevant for any well-formed #line directive. This is done for
consistency and ultimate safety.
Reported-by: Ian Campbell <Ian.Campbell@citrix.com>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'convert-dtsv0-lexer.l')
0 files changed, 0 insertions, 0 deletions