diff options
author | Jon Loeliger <jdl@jdl.com> | 2008-10-03 11:12:33 -0500 |
---|---|---|
committer | Jon Loeliger <jdl@jdl.com> | 2008-10-03 11:12:33 -0500 |
commit | 879e4d2590b50d63f82c3c3652bc3c7900591f1c (patch) | |
tree | 360150a0a9f7b94f455ace32fc5145898d4c4b2f /flattree.c | |
parent | 68f98d7b8aa41fab175daf9f1bcb2a5bc22dbc90 (diff) | |
download | dtc-879e4d2590b50d63f82c3c3652bc3c7900591f1c.tar.gz |
Implement and use an xstrdup() function
Many places in dtc use strdup(), but none of them actually check the
return value to see if the implied allocation succeeded. This is a
potential bug, which we fix in the patch below by replacing strdup()
with an xstrdup() which in analogy to xmalloc() will quit with a fatal
error if the allocation fails.
I felt the introduciton of util.[ch] was a better choice
for utility oriented code than directly using srcpos.c
for the new string function.
This patch is a re-factoring of Dave Gibson's similar patch.
Signed-off-by: Jon Loeliger <jdl@freescale.com>
Diffstat (limited to 'flattree.c')
-rw-r--r-- | flattree.c | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -601,7 +601,7 @@ static char *flat_read_string(struct inbuf *inb) len++; } while ((*p++) != '\0'); - str = strdup(inb->ptr); + str = xstrdup(inb->ptr); inb->ptr += len; @@ -643,7 +643,7 @@ static char *flat_read_stringtable(struct inbuf *inb, int offset) p++; } - return strdup(inb->base + offset); + return xstrdup(inb->base + offset); } static struct property *flat_read_property(struct inbuf *dtbuf, @@ -710,7 +710,7 @@ static char *nodename_from_path(const char *ppath, const char *cpath) if (!streq(ppath, "/")) plen++; - return strdup(cpath + plen); + return xstrdup(cpath + plen); } static struct node *unflatten_tree(struct inbuf *dtbuf, |