summaryrefslogtreecommitdiff
path: root/fstree.c
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2008-03-06 12:16:55 +1100
committerJon Loeliger <jdl@loeliger.com>2008-03-23 08:00:33 -0500
commitf7ea3708c38bd38851baafa83e98d95602e53cbc (patch)
treec6acbffa899a43be4336d7e695715c2fffcc8d60 /fstree.c
parent6c2e4d61f83af4233c3270e4f1ec1da01d90466e (diff)
downloaddtc-f7ea3708c38bd38851baafa83e98d95602e53cbc.tar.gz
dtc: Make dtc_open_file() die() if unable to open requested file
All current callers of dtc_open_file() immediately die() if it returns an error. In a non-interative tool like dtc, it's hard to see what you could sensibly do to recover from a failure to open an input file in any case. Therefore, make dtc_open_file() itself die() if there's an error opening the requested file. This removes the need for error checking at the callsites, and ensures a consistent error message in all cases. While we're at it, change the rror message from fstree.c when we fail to open the input directory to match dtc_open_file()'s error message. Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'fstree.c')
-rw-r--r--fstree.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fstree.c b/fstree.c
index 2fc5773..0c0bdf0 100644
--- a/fstree.c
+++ b/fstree.c
@@ -31,8 +31,8 @@ static struct node *read_fstree(const char *dirname)
struct node *tree;
d = opendir(dirname);
- if (! d)
- die("opendir(): %s\n", strerror(errno));
+ if (!d)
+ die("Couldn't opendir() \"%s\": %s\n", dirname, strerror(errno));
tree = build_node(NULL, NULL);