diff options
author | Lukas Czerner <lczerner@redhat.com> | 2020-02-10 16:24:59 +0100 |
---|---|---|
committer | Theodore Ts'o <tytso@mit.edu> | 2020-02-27 22:31:14 -0500 |
commit | 336c440ccea8f94b0728f881cddee84f730e7cc7 (patch) | |
tree | 29adf7a6694cd7fb346bcf96b2c743eea9b8e66d /e2fsck/e2fsck.h | |
parent | a5676f8da792062f4c0e8ee49e0a5f0877268411 (diff) | |
download | e2fsprogs-336c440ccea8f94b0728f881cddee84f730e7cc7.tar.gz |
tst_libext2fs: Avoid multiple definition of global variables
gcc version 10 changed the default from -fcommon to -fno-common and as a
result e2fsprogs make check tests fail because tst_libext2fs.c end up
with a build error.
This is because it defines two global variables debug_prog_name and
extra_cmds that are already defined in debugfs/debugfs.c. With -fcommon
linker was able to resolve those into the same object, however with
-fno-common it's no longer able to do it and we end up with multiple
definition errors.
Fix the problem by using SKIP_GLOBDEFS macro to skip the variables
definition in debugfs.c. Note that debug_prog_name is also defined in
lib/ext2fs/extent.c when DEBUG macro is used, but this does not work even
with older gcc versions and is never used regardless so I am not going to
bother with it.
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'e2fsck/e2fsck.h')
0 files changed, 0 insertions, 0 deletions