summaryrefslogtreecommitdiff
path: root/e2fsck/journal.c
diff options
context:
space:
mode:
authorTheodore Ts'o <tytso@mit.edu>2022-08-12 22:34:57 -0400
committerTheodore Ts'o <tytso@mit.edu>2022-08-12 22:34:57 -0400
commitd05a33bd3e255d8d279b3399eadccbcaeb3613a5 (patch)
treec1837ecd2fd4fa708e878c538a91ca7c85d74ed1 /e2fsck/journal.c
parentd5aba8e5d349272eb221e2aab3775bb942f89684 (diff)
parent18ebcf26f478702cd09dd4229320d449469f1490 (diff)
downloade2fsprogs-d05a33bd3e255d8d279b3399eadccbcaeb3613a5.tar.gz
Merge branch 'maint' into next
Diffstat (limited to 'e2fsck/journal.c')
-rw-r--r--e2fsck/journal.c14
1 files changed, 12 insertions, 2 deletions
diff --git a/e2fsck/journal.c b/e2fsck/journal.c
index 3cd3e306..d802c5e9 100644
--- a/e2fsck/journal.c
+++ b/e2fsck/journal.c
@@ -747,9 +747,19 @@ static int ext4_fc_handle_inode(e2fsck_t ctx, __u8 *val)
fc_raw_inode = val + sizeof(fc_ino);
ino = le32_to_cpu(fc_ino);
- if (EXT2_INODE_SIZE(ctx->fs->super) > EXT2_GOOD_OLD_INODE_SIZE)
- inode_len += ext2fs_le16_to_cpu(
+ if (EXT2_INODE_SIZE(ctx->fs->super) > EXT2_GOOD_OLD_INODE_SIZE) {
+ __u16 extra_isize = ext2fs_le16_to_cpu(
((struct ext2_inode_large *)fc_raw_inode)->i_extra_isize);
+
+ if ((extra_isize < (sizeof(inode->i_extra_isize) +
+ sizeof(inode->i_checksum_hi))) ||
+ (extra_isize > (EXT2_INODE_SIZE(ctx->fs->super) -
+ EXT2_GOOD_OLD_INODE_SIZE))) {
+ err = EFSCORRUPTED;
+ goto out;
+ }
+ inode_len += extra_isize;
+ }
err = ext2fs_get_mem(inode_len, &inode);
if (err)
goto out;