summaryrefslogtreecommitdiff
path: root/config
diff options
context:
space:
mode:
authorMark Wielaard <mark@klomp.org>2018-11-19 11:46:46 +0100
committerMark Wielaard <mark@klomp.org>2018-11-21 12:30:12 +0100
commitf5810ec76caed5155c27c2ed3d0ba2b3f0d4ad22 (patch)
tree63fa7eeda9f38e99499819fbcfe063c45a6cab01 /config
parentc93f060df3648f0e219ed8d041045d91bbc9dc70 (diff)
downloadelfutils-f5810ec76caed5155c27c2ed3d0ba2b3f0d4ad22.tar.gz
Add -Wtrampolines to CFLAGS.
elfutils uses nested functions a lot. This is fine unless one takes the address of such a nested function. When taking the address of a nested function a trampoline is generated that on some systems require the stack to be executable. That is bad. We never want to generate such trampolines. Add -Wtrampolines to CLAGS to make sure we don't. Signed-off-by: Mark Wielaard <mark@klomp.org>
Diffstat (limited to 'config')
-rw-r--r--config/ChangeLog4
-rw-r--r--config/eu.am2
2 files changed, 5 insertions, 1 deletions
diff --git a/config/ChangeLog b/config/ChangeLog
index f281eb27..40d6f85a 100644
--- a/config/ChangeLog
+++ b/config/ChangeLog
@@ -1,3 +1,7 @@
+2018-11-19 Mark Wielaard <mark@klomp.org>
+
+ * eu.am (AM_CFLAGS): Add -Wtrampolines.
+
2018-07-04 Mark Wielaard <mark@klomp.org>
* upload-release.sh: New file.
diff --git a/config/eu.am b/config/eu.am
index c2cc349c..82acda3a 100644
--- a/config/eu.am
+++ b/config/eu.am
@@ -70,7 +70,7 @@ IMPLICIT_FALLTHROUGH_WARNING=
endif
AM_CFLAGS = -std=gnu99 -Wall -Wshadow -Wformat=2 \
- -Wold-style-definition -Wstrict-prototypes \
+ -Wold-style-definition -Wstrict-prototypes -Wtrampolines \
$(LOGICAL_OP_WARNING) $(DUPLICATED_COND_WARNING) \
$(NULL_DEREFERENCE_WARNING) $(IMPLICIT_FALLTHROUGH_WARNING) \
$(if $($(*F)_no_Werror),,-Werror) \