diff options
| author | Stefan Kangas <stefan@marxist.se> | 2022-07-08 12:04:17 +0200 |
|---|---|---|
| committer | Stefan Kangas <stefan@marxist.se> | 2022-07-08 12:10:33 +0200 |
| commit | 9abf841429257a3e1008bedc4d857ea7a25ab9a6 (patch) | |
| tree | 6825e2d0cb1d21d26b8a3601358ff328a3a092e4 /lisp/ffap.el | |
| parent | 38697a07c0f2b99b76c41cb1096543681342a405 (diff) | |
| download | emacs-9abf841429257a3e1008bedc4d857ea7a25ab9a6.tar.gz | |
Stop ffap-machine-at-point from pinging random hosts
Having this on by default is highly problematic from a security and
privacy standpoint, as it risks having outgoing traffic that could
potentially reveal sensitive data (passwords, names, etc.).
It also seems to be causing issues for users, see e.g.
https://github.com/emacs-helm/helm/issues/648
* lisp/ffap.el (ffap-machine-p-known): Change default to 'accept'.
Diffstat (limited to 'lisp/ffap.el')
| -rw-r--r-- | lisp/ffap.el | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/lisp/ffap.el b/lisp/ffap.el index 20929c659de..65e0779e400 100644 --- a/lisp/ffap.el +++ b/lisp/ffap.el @@ -1,6 +1,6 @@ ;;; ffap.el --- find file (or url) at point -*- lexical-binding: t -*- -;; Copyright (C) 1995-1997, 2000-2022 Free Software Foundation, Inc. +;; Copyright (C) 1995-2022 Free Software Foundation, Inc. ;; Author: Michelangelo Grigni <mic@mathcs.emory.edu> ;; Maintainer: emacs-devel@gnu.org @@ -394,7 +394,7 @@ Value should be a symbol, one of `ping', `accept', and `reject'." :safe #'ffap--accept-or-reject-p :group 'ffap) -(defcustom ffap-machine-p-known 'ping ; `accept' for higher speed +(defcustom ffap-machine-p-known 'accept "What `ffap-machine-p' does with hostnames that have a known domain. Value should be a symbol, one of `ping', `accept', and `reject'. See `mail-extr.el' for the known domains." @@ -402,7 +402,8 @@ See `mail-extr.el' for the known domains." (const accept) (const reject)) :safe #'ffap--accept-or-reject-p - :group 'ffap) + :group 'ffap + :version "29.1") (defcustom ffap-machine-p-unknown 'reject "What `ffap-machine-p' does with hostnames that have an unknown domain. |