eo: fix missing event emissiondevs/bu5hm4n/review

There have been cases where the logic of _event_callback_call break'ed
too early in the event submission.
Reason for that was the line ((const unsigned char *) desc -
(const unsigned char *) it->desc) producing a overflow.

This means the if statement

if (!legacy_compare &&
   ((const unsigned char *) desc - (const unsigned char *) it->desc) < 0)

was true while the pointer desc was smaller than it->desc, which means
the event subscription got aborted, even if it should not.

This turned out on two 32 bit maschines. And led to not rendering apps
anymore.

It was introduced by commit in 605fec91ee7.

@fix

1 files changed, 1 insertions, 1 deletions

diff --git a/src/lib/eo/eo_base_class.c b/src/lib/eo/eo_base_class.c
index 18c25bfc4d..6d05aed81d 100644
--- a/src/lib/eo/eo_base_class.c
+++ b/src/lib/eo/eo_base_class.c
@@ -1460,7 +1460,7 @@ restart_back:
                     {
                        // Array callbacks are sorted, break if we are getting to high.
                        if (!legacy_compare &&
-                           ((const unsigned char *) desc - (const unsigned char *) it->desc) < 0)
+                           ((const unsigned char *) desc < (const unsigned char *) it->desc))
                          break;
                        if (!_cb_desc_match(it->desc, desc, legacy_compare))
                           continue;