summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarcel Hollerbach <mail@marcel-hollerbach.de>2020-01-17 14:42:17 +0100
committerMarcel Hollerbach <mail@marcel-hollerbach.de>2020-01-17 14:46:53 +0100
commitea742648adc9c03b55d4c5b407751dabf3191233 (patch)
tree63082bcf4de6bce01a41e4a352f6b26a94707993
parent59272b15304fc6960037bbcc38162346534e73d8 (diff)
downloadefl-devs/bu5hm4n/work_tests.tar.gz
efl_ui_suite: fix test code of griddevs/bu5hm4n/work_tests
this test code seemed buggy, we used the iterator *after* the content was changed. Additionally, we freed the iterator with free instead of eina_iterator_free. This fixes test test suite. Differential Revision: https://phab.enlightenment.org/D11124
-rw-r--r--src/tests/elementary/efl_ui_test_grid.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/src/tests/elementary/efl_ui_test_grid.c b/src/tests/elementary/efl_ui_test_grid.c
index 7ec1763545..db19e58d87 100644
--- a/src/tests/elementary/efl_ui_test_grid.c
+++ b/src/tests/elementary/efl_ui_test_grid.c
@@ -89,16 +89,15 @@ EFL_START_TEST(efl_ui_grid_unpack_all)
ck_assert(grid_item_pack(grid, count_before, NULL) != EINA_FALSE);
- itor = efl_content_iterate(grid);
efl_pack_unpack_all(grid);
count = efl_content_count(grid);
ck_assert(count == 0);
+ itor = efl_content_iterate(grid);
EINA_ITERATOR_FOREACH(itor, item)
- efl_del(item);
-
- free(itor);
+ ck_assert(EINA_FALSE);
+ eina_iterator_free(itor);
}
EFL_END_TEST