diff options
| author | Daniel Juyung Seo <seojuyung2@gmail.com> | 2014-05-10 23:41:10 +0900 |
|---|---|---|
| committer | Daniel Juyung Seo <seojuyung2@gmail.com> | 2014-05-10 23:44:28 +0900 |
| commit | 842b9e3cc4da3977c1ef05c8498dd5573d0cc917 (patch) | |
| tree | a3f6f38c0b6eea80b24acbd7358fc8c295034513 | |
| parent | b156b600fa32a4fa58f2e0bbd8e41079b8ec6527 (diff) | |
| download | elementary-devs/seoz/pre1.11.tar.gz | |
list: added comments about an unused function.devs/seoz/pre1.11
Fixing this issue is not trivial and will bring another issues like crashing.
So it is better to fix this in a development phase by refactoring list.
To fix this issue, the following are needed:
1. it->walking concept should be adopted instead of using just sd->walking.
sd->walking was introduced in beb418d6
2. elm_widget_item_del() should be called instead of the combination of
_elm_list_item_free() + elm_widget_item_free()
This was introduced in f343011d
| -rw-r--r-- | src/lib/elm_list.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/lib/elm_list.c b/src/lib/elm_list.c index dedc4a1f5..0098d1cb3 100644 --- a/src/lib/elm_list.c +++ b/src/lib/elm_list.c @@ -1869,6 +1869,12 @@ _item_text_get_hook(const Elm_Object_Item *it, return ((Elm_List_Item *)it)->label; } +/* FIXME: this _item_del_pre_hook is never been called at all! + To fix this, + 1. it->walking concept should be adopted. + 2. elm_widget_item_del() should be called instead of the combination of + _elm_list_item_free() + elm_widget_item_free() + */ static Eina_Bool _item_del_pre_hook(Elm_Object_Item *it) { |