summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMichael Niedermayer <michael@niedermayer.cc>2020-06-30 22:01:22 +0200
committerMichael Niedermayer <michael@niedermayer.cc>2020-07-07 19:30:17 +0200
commit11c1e1d6d0eac199ef6c036c946b05a1b463b644 (patch)
tree81e09ca0afef9a23f0f9314f04dc417cbb293ea1
parentb8f3879bcca06f6277a9462d385868643f22379f (diff)
downloadffmpeg-11c1e1d6d0eac199ef6c036c946b05a1b463b644.tar.gz
avcodec/apedec: Fix undefined integer overflow with 24bit
Fixes: signed integer overflow: 8683744 * 256 cannot be represented in type 'int' Fixes: 23527/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5679885932822528 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> (cherry picked from commit 9f7b252cdf2d0e0f79d16dc7cd575d1884239863) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
-rw-r--r--libavcodec/apedec.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c
index 93e9a18e5d..3bec1eee68 100644
--- a/libavcodec/apedec.c
+++ b/libavcodec/apedec.c
@@ -1543,7 +1543,7 @@ static int ape_decode_frame(AVCodecContext *avctx, void *data,
for (ch = 0; ch < s->channels; ch++) {
sample24 = (int32_t *)frame->data[ch];
for (i = 0; i < blockstodecode; i++)
- *sample24++ = s->decoded[ch][i] * 256;
+ *sample24++ = s->decoded[ch][i] * 256U;
}
break;
}