summaryrefslogtreecommitdiff
path: root/libavcodec/dnxhddec.c
diff options
context:
space:
mode:
authorPaul B Mahol <onemda@gmail.com>2017-04-11 00:08:39 +0200
committerPaul B Mahol <onemda@gmail.com>2017-04-11 00:08:39 +0200
commit25e491b6f9dba26bd4a10c256150debfb13252db (patch)
treed78009055fda48e0e8f1761d6cf942c880afadcb /libavcodec/dnxhddec.c
parent27ebdcf079ed54d294db010e9f50700f75ed5e3d (diff)
downloadffmpeg-25e491b6f9dba26bd4a10c256150debfb13252db.tar.gz
avcodec/dnxhddec: add support for very big resolutions
Signed-off-by: Paul B Mahol <onemda@gmail.com>
Diffstat (limited to 'libavcodec/dnxhddec.c')
-rw-r--r--libavcodec/dnxhddec.c10
1 files changed, 7 insertions, 3 deletions
diff --git a/libavcodec/dnxhddec.c b/libavcodec/dnxhddec.c
index 383e64ca9e..cc24ebd58a 100644
--- a/libavcodec/dnxhddec.c
+++ b/libavcodec/dnxhddec.c
@@ -58,7 +58,7 @@ typedef struct DNXHDContext {
unsigned int width, height;
enum AVPixelFormat pix_fmt;
unsigned int mb_width, mb_height;
- uint32_t mb_scan_index[256];
+ uint32_t mb_scan_index[512];
int data_offset; // End of mb_scan_index, where macroblocks start
int cur_field; ///< current interlaced field
VLC ac_vlc, dc_vlc, run_vlc;
@@ -285,7 +285,7 @@ static int dnxhd_decode_header(DNXHDContext *ctx, AVFrame *frame,
}
ctx->mb_width = (ctx->width + 15)>> 4;
- ctx->mb_height = buf[0x16d];
+ ctx->mb_height = AV_RB16(buf + 0x16c);
if ((ctx->height + 15) >> 4 == ctx->mb_height && frame->interlaced_frame)
ctx->height <<= 1;
@@ -313,7 +313,11 @@ static int dnxhd_decode_header(DNXHDContext *ctx, AVFrame *frame,
return AVERROR_INVALIDDATA;
}
- av_assert0((unsigned)ctx->mb_height <= FF_ARRAY_ELEMS(ctx->mb_scan_index));
+ if (ctx->mb_height > FF_ARRAY_ELEMS(ctx->mb_scan_index)) {
+ av_log(ctx->avctx, AV_LOG_ERROR,
+ "mb_height too big (%d > %"PRIu64").\n", ctx->mb_height, FF_ARRAY_ELEMS(ctx->mb_scan_index));
+ return AVERROR_INVALIDDATA;
+ }
for (i = 0; i < ctx->mb_height; i++) {
ctx->mb_scan_index[i] = AV_RB32(buf + 0x170 + (i << 2));