summaryrefslogtreecommitdiff
path: root/libavformat/libsrt.c
diff options
context:
space:
mode:
authorNicolas Sugino <nsugino@3way.com.ar>2020-08-13 22:18:26 -0300
committerMarton Balint <cus@passwd.hu>2020-08-20 16:24:46 +0200
commit86f5fd471d35423e3bd5c9d2bd0076b14124faee (patch)
tree5ccb73456ba4857eefe1b2516cefca1982daf21b /libavformat/libsrt.c
parent8931c55789a69f717b4a6954c5bb7acf5475a134 (diff)
downloadffmpeg-86f5fd471d35423e3bd5c9d2bd0076b14124faee.tar.gz
avformat/libsrt: close listen fd in listener mode
In listener mode the first fd is not closed when libsrt_close() is called because it is overwritten by the new accept fd. Added the listen_fd to the context to properly close it when libsrt_close() is called. Fixes trac ticket #8372. Signed-off-by: Nicolas Sugino <nsugino@3way.com.ar> Signed-off-by: Marton Balint <cus@passwd.hu>
Diffstat (limited to 'libavformat/libsrt.c')
-rw-r--r--libavformat/libsrt.c12
1 files changed, 11 insertions, 1 deletions
diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c
index 4719ce0d4b..4025b24976 100644
--- a/libavformat/libsrt.c
+++ b/libavformat/libsrt.c
@@ -53,6 +53,7 @@ enum SRTMode {
typedef struct SRTContext {
const AVClass *class;
int fd;
+ int listen_fd;
int eid;
int64_t rw_timeout;
int64_t listen_timeout;
@@ -362,7 +363,7 @@ static int libsrt_set_options_pre(URLContext *h, int fd)
static int libsrt_setup(URLContext *h, const char *uri, int flags)
{
struct addrinfo hints = { 0 }, *ai, *cur_ai;
- int port, fd = -1;
+ int port, fd = -1, listen_fd = -1;
SRTContext *s = h->priv_data;
const char *p;
char buf[256];
@@ -439,6 +440,7 @@ static int libsrt_setup(URLContext *h, const char *uri, int flags)
// multi-client
if ((ret = libsrt_listen(s->eid, fd, cur_ai->ai_addr, cur_ai->ai_addrlen, h, s->listen_timeout)) < 0)
goto fail1;
+ listen_fd = fd;
fd = ret;
} else {
if (s->mode == SRT_MODE_RENDEZVOUS) {
@@ -471,6 +473,7 @@ static int libsrt_setup(URLContext *h, const char *uri, int flags)
h->is_streamed = 1;
s->fd = fd;
+ s->listen_fd = listen_fd;
freeaddrinfo(ai);
return 0;
@@ -481,12 +484,16 @@ static int libsrt_setup(URLContext *h, const char *uri, int flags)
cur_ai = cur_ai->ai_next;
if (fd >= 0)
srt_close(fd);
+ if (listen_fd >= 0)
+ srt_close(listen_fd);
ret = 0;
goto restart;
}
fail1:
if (fd >= 0)
srt_close(fd);
+ if (listen_fd >= 0)
+ srt_close(listen_fd);
freeaddrinfo(ai);
return ret;
}
@@ -676,6 +683,9 @@ static int libsrt_close(URLContext *h)
srt_close(s->fd);
+ if (s->listen_fd >= 0)
+ srt_close(s->listen_fd);
+
srt_epoll_release(s->eid);
srt_cleanup();