summaryrefslogtreecommitdiff
path: root/libavfilter/af_sidechaincompress.c
Commit message (Collapse)AuthorAgeFilesLines
* configure: Use a separate config_components.h header for $ALL_COMPONENTSMartin Storsjö2022-03-161-0/+2
| | | | | | | | This avoids unnecessary rebuilds of most source files if only the list of enabled components has changed, but not the other properties of the build, set in config.h. Signed-off-by: Martin Storsjö <martin@martin.st>
* avfilter: convert to new channel layout APIJames Almer2022-03-151-9/+9
| | | | Signed-off-by: James Almer <jamrial@gmail.com>
* avfilter/af_sidechaincompress: Store format in filter, remove query funcAndreas Rheinhardt2021-10-051-18/+1
| | | | Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
* avfilter: Replace query_formats callback with union of list and callbackAndreas Rheinhardt2021-10-051-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If one looks at the many query_formats callbacks in existence, one will immediately recognize that there is one type of default callback for video and a slightly different default callback for audio: It is "return ff_set_common_formats_from_list(ctx, pix_fmts);" for video with a filter-specific pix_fmts list. For audio, it is the same with a filter-specific sample_fmts list together with ff_set_common_all_samplerates() and ff_set_common_all_channel_counts(). This commit allows to remove the boilerplate query_formats callbacks by replacing said callback with a union consisting the old callback and pointers for pixel and sample format arrays. For the not uncommon case in which these lists only contain a single entry (besides the sentinel) enum AVPixelFormat and enum AVSampleFormat fields are also added to the union to store them directly in the AVFilter, thereby avoiding a relocation. The state of said union will be contained in a new, dedicated AVFilter field (the nb_inputs and nb_outputs fields have been shrunk to uint8_t in order to create a hole for this new field; this is no problem, as the maximum of all the nb_inputs is four; for nb_outputs it is only two). The state's default value coincides with the earlier default of query_formats being unset, namely that the filter accepts all formats (and also sample rates and channel counts/layouts for audio) provided that these properties agree coincide for all inputs and outputs. By using different union members for audio and video filters the type-unsafety of using the same functions for audio and video lists will furthermore be more confined to formats.c than before. When the new fields are used, they will also avoid allocations: Currently something nearly equivalent to ff_default_query_formats() is called after every successful call to a query_formats callback; yet in the common case that the newly allocated AVFilterFormats are not used at all (namely if there are no free links) these newly allocated AVFilterFormats are freed again without ever being used. Filters no longer using the callback will not exhibit this any more. Reviewed-by: Paul B Mahol <onemda@gmail.com> Reviewed-by: Nicolas George <george@nsup.org> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
* avfilter/af_sidechaincompress: Remove always-false samplerate checkAndreas Rheinhardt2021-09-211-9/+0
| | | | | | | | | | This filter uses ff_set_common_all_samplerates(). Also don't overwrite outlink->sample_rate in config_output; it is harmless, because it is overwritten with the value it already had, but it is an API violation. Reviewed-by: Paul B Mahol <onemda@gmail.com> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
* avfilter/af_sidechaincompress: Honour query_formats API, fix segfaultAndreas Rheinhardt2021-09-211-19/+7
| | | | | | | | | | | | | | | | | | | | Just like the sidechaingate filter, the sidechaincompress filter overwrote the channel layout and channel count of its output in its config_output callback to match the channel layout of its main input instead of linking the main input and its output together in its query_formats callback. This is an API violation that can lead to segfaults, as in the following filtergraph, where stereotools rightly expects stereo, yet receives only mono: [in]aformat=channel_layouts=mono,aformat=channel_layouts=stereo|mono[out];\ [out][in2]sidechaincompress,stereotools Fix this by linking the channel layouts of the main input and the output in query_formats and remove the code overwriting it in config_output. Reviewed-by: Paul B Mahol <onemda@gmail.com> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
* avfilter/af_sidechaincompress: Deduplicate AVClassesAndreas Rheinhardt2021-09-191-7/+5
| | | | Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
* avfilter/avfilter: Add numbers of (in|out)pads directly to AVFilterAndreas Rheinhardt2021-08-201-8/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Up until now, an AVFilter's lists of input and output AVFilterPads were terminated by a sentinel and the only way to get the length of these lists was by using avfilter_pad_count(). This has two drawbacks: first, sizeof(AVFilterPad) is not negligible (i.e. 64B on 64bit systems); second, getting the size involves a function call instead of just reading the data. This commit therefore changes this. The sentinels are removed and new private fields nb_inputs and nb_outputs are added to AVFilter that contain the number of elements of the respective AVFilterPad array. Given that AVFilter.(in|out)puts are the only arrays of zero-terminated AVFilterPads an API user has access to (AVFilterContext.(in|out)put_pads are not zero-terminated and they already have a size field) the argument to avfilter_pad_count() is always one of these lists, so it just has to find the filter the list belongs to and read said number. This is slower than before, but a replacement function that just reads the internal numbers that users are expected to switch to will be added soon; and furthermore, avfilter_pad_count() is probably never called in hot loops anyway. This saves about 49KiB from the binary; notice that these sentinels are not in .bss despite being zeroed: they are in .data.rel.ro due to the non-sentinels. Reviewed-by: Nicolas George <george@nsup.org> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
* avfilter/formats: Factor common function combinations outAndreas Rheinhardt2021-08-131-21/+5
| | | | | | | | | | | Several combinations of functions happen quite often in query_format functions; e.g. ff_set_common_formats(ctx, ff_make_format_list(sample_fmts)) is very common. This commit therefore adds functions that are equivalent to commonly used function combinations in order to reduce code duplication. Reviewed-by: Nicolas George <george@nsup.org> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
* Remove unnecessary avassert.h inclusionsAndreas Rheinhardt2021-07-221-1/+0
| | | | Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
* avfilter: Constify all AVFiltersAndreas Rheinhardt2021-04-271-2/+2
| | | | | | | This is possible now that the next-API is gone. Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com> Signed-off-by: James Almer <jamrial@gmail.com>
* lavfi: regroup formats lists in a single structure.Nicolas George2020-09-081-5/+5
| | | | | | | | | | | | | | | It will allow to refernce it as a whole without clunky macros. Most of the changes have been automatically made with sed: sed -i ' s/-> *in_formats/->incfg.formats/g; s/-> *out_formats/->outcfg.formats/g; s/-> *in_channel_layouts/->incfg.channel_layouts/g; s/-> *out_channel_layouts/->outcfg.channel_layouts/g; s/-> *in_samplerates/->incfg.samplerates/g; s/-> *out_samplerates/->outcfg.samplerates/g; ' src/libavfilter/*(.)
* avfilter/af_sidechaincompress: add support for commandsPaul B Mahol2020-01-061-18/+35
|
* avfilter/af_sidechaincompress: fix pts handling when timebase and ↵Paul B Mahol2019-11-171-1/+1
| | | | 1/samplerate differ
* avfilter/af_sidechaincompress: implement mode optionPaul B Mahol2019-04-171-8/+39
|
* avfilter: pass outlink to ff_get_audio_buffer()Paul B Mahol2018-01-031-1/+1
| | | | | | This is more correct. Signed-off-by: Paul B Mahol <onemda@gmail.com>
* avfilter: fix indentationPaul B Mahol2017-11-191-8/+7
| | | | Signed-off-by: Paul B Mahol <onemda@gmail.com>
* lavfi/af_sidechaincompress: use helper macros.Nicolas George2017-09-121-10/+5
|
* avfilter/af_sidechaincompress: switch to activatePaul B Mahol2017-08-241-54/+58
|
* avfilter/af_sidechaincompress: change default makeup gain to 1Paul B Mahol2017-05-201-1/+1
| | | | | | This avoids producing out of range or clipped samples. Signed-off-by: Paul B Mahol <onemda@gmail.com>
* avfilter/af_sidechaincompress: Free out frame on errorMichael Niedermayer2016-02-031-1/+2
| | | | | | | Fix memleak Fixes CID1197065 part 2 Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
* avfilter/af_sidechaincompress & af_agate: use audio fifo from lavuPaul B Mahol2016-01-151-27/+50
| | | | | | Fixes regression causing segfault. Signed-off-by: Paul B Mahol <onemda@gmail.com>
* avfilter/af_sidechaincompress: kill init functionPaul B Mahol2015-12-031-16/+7
| | | | | | Should make addition of process_command easier. Signed-off-by: Paul B Mahol <onemda@gmail.com>
* avfilter/af_sidechaincompress: do not require writable input frames for ↵Paul B Mahol2015-11-301-10/+25
| | | | | | acompressor filter Signed-off-by: Paul B Mahol <onemda@gmail.com>
* avfilter/af_sidechaincompress: add level_in and level_sc optionsPaul B Mahol2015-11-301-17/+24
| | | | Signed-off-by: Paul B Mahol <onemda@gmail.com>
* avfilter/af_sidechaincompress: fix output gain for rms(default) detectionPaul B Mahol2015-11-291-1/+3
| | | | Signed-off-by: Paul B Mahol <onemda@gmail.com>
* avfilter: add audio compressor filterPaul B Mahol2015-11-281-29/+128
| | | | Signed-off-by: Paul B Mahol <onemda@gmail.com>
* avfilter/af_sidechaincompress: add forgotten optionPaul B Mahol2015-11-251-1/+4
| | | | Signed-off-by: Paul B Mahol <onemda@gmail.com>
* avfilter/all: propagate errors of functions from avfilter/formatsGanesh Ajjanagadde2015-10-141-13/+6
| | | | | | | | | | | | | | | | | | Many of the functions from avfilter/formats can return errors, usually AVERROR(ENOMEM). This propagates the return values. All of these were found by using av_warn_unused_result, demonstrating its utility. Tested with FATE. I am least sure of the changes to avfilter/filtergraph, since I don't know what/how reduce_format is intended to behave and how it should react to errors. Fixes: CID 1325680, 1325679, 1325678. Reviewed-by: Michael Niedermayer <michael@niedermayer.cc> Previous version Reviewed-by: Nicolas George <george@nsup.org> Previous version Reviewed-by: Clément Bœsch <u@pkh.me> Signed-off-by: Ganesh Ajjanagadde <gajjanagadde@gmail.com>
* avfilter/af_sidechaincompress: replace FFABS with fabsGanesh Ajjanagadde2015-10-131-3/+3
|
* avfilter: add agate filterPaul B Mahol2015-09-221-23/+1
| | | | Signed-off-by: Paul B Mahol <onemda@gmail.com>
* avfilter/af_sidechaincompress: do not use floatsPaul B Mahol2015-09-171-2/+2
| | | | Signed-off-by: Paul B Mahol <onemda@gmail.com>
* avfilter/af_sidechaincompress: use doubles instead of floatsPaul B Mahol2015-09-171-7/+7
| | | | Signed-off-by: Paul B Mahol <onemda@gmail.com>
* avfilter: use ff_all_channel_counts() instead of ff_all_channel_layouts()Paul B Mahol2015-09-121-1/+1
| | | | | | Fixes playback of some files with ffplay. Signed-off-by: Paul B Mahol <onemda@gmail.com>
* avfilter/af_sidechaincompress: Also assert that i < 2Michael Niedermayer2015-09-031-1/+1
| | | | | | This should help static analyzers (CID1322339) Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
* avfilter: add sidechain compress audio filterPaul B Mahol2015-07-251-0/+338
Signed-off-by: Paul B Mahol <onemda@gmail.com>
View Lorry Controller Status