diff options
| author | Nico Huber <nico.h@gmx.de> | 2018-12-23 20:03:35 +0100 |
|---|---|---|
| committer | Nico Huber <nico.h@gmx.de> | 2019-07-31 08:26:59 +0000 |
| commit | 519be66fc59558971dd653afe69ccaf1a633b492 (patch) | |
| tree | 74f0912de156a86d56111f377db080246e5205e9 /at45db.c | |
| parent | ef78de4a21323b8c459337356289218211f2c5ce (diff) | |
| download | flashrom-git-519be66fc59558971dd653afe69ccaf1a633b492.tar.gz | |
Fix -Wsign-compare trouble
Mostly by changing to `unsigned` types where applicable, sometimes
`signed` types, and casting as a last resort.
Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/30409
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jacob Garber <jgarber1@ualberta.ca>
Diffstat (limited to 'at45db.c')
| -rw-r--r-- | at45db.c | 6 |
1 files changed, 3 insertions, 3 deletions
@@ -463,9 +463,9 @@ static int at45db_fill_buffer1(struct flashctx *flash, const uint8_t *bytes, uns } /* Create a suitable buffer to store opcode, address and data chunks for buffer1. */ - const int max_data_write = flash->mst->spi.max_data_write - 4; - const unsigned int max_chunk = (max_data_write > 0 && max_data_write <= page_size) ? - max_data_write : page_size; + const unsigned int max_data_write = flash->mst->spi.max_data_write; + const unsigned int max_chunk = max_data_write > 4 && max_data_write - 4 <= page_size ? + max_data_write - 4 : page_size; uint8_t buf[4 + max_chunk]; buf[0] = AT45DB_BUFFER1_WRITE; |