diff options
| author | stefanct <stefanct@2b7e53f0-3cfb-0310-b3e9-8179ed1497e1> | 2013-09-14 09:02:27 +0000 |
|---|---|---|
| committer | stefanct <stefanct@2b7e53f0-3cfb-0310-b3e9-8179ed1497e1> | 2013-09-14 09:02:27 +0000 |
| commit | 4e4d4dffd9719f832f8787df393b95dfad8f4cc5 (patch) | |
| tree | 1d4a18ad60037ced5824c9f509dd77997f56054a /cbtable.c | |
| parent | fdbbfbb4322020a4f32290319172bd14e24e75b7 (diff) | |
| download | flashrom-4e4d4dffd9719f832f8787df393b95dfad8f4cc5.tar.gz | |
Remove exit call and mayfail parameter from physmap_common().
The only call path where exit was reached was from physmap functions.
Callers of physmap() et al. which were not prepared to handle
ERROR_PTR return values have been adjusted.
physmap_try_ro() has been renamed to physmap_ro() and physmap_common()
slightly refactored due to the now removed *FAIL parameters.
Signed-off-by: Niklas Söderlund <niso@kth.se>
Signed-off-by: Stefan Tauner <stefan.tauner@student.tuwien.ac.at>
Acked-by: Stefan Tauner <stefan.tauner@student.tuwien.ac.at>
git-svn-id: https://code.coreboot.org/svn/flashrom/trunk@1745 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'cbtable.c')
| -rw-r--r-- | cbtable.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -261,7 +261,7 @@ int cb_parse_table(const char **vendor, const char **model) #else start = 0x0; #endif - table_area = physmap_try_ro("low megabyte", start, BYTES_TO_MAP - start); + table_area = physmap_ro("low megabyte", start, BYTES_TO_MAP - start); if (ERROR_PTR == table_area) { msg_perr("Failed getting access to coreboot low tables.\n"); return -1; @@ -277,7 +277,7 @@ int cb_parse_table(const char **vendor, const char **model) start = forward->forward; start &= ~(getpagesize() - 1); physunmap(table_area, BYTES_TO_MAP); - table_area = physmap_try_ro("high tables", start, BYTES_TO_MAP); + table_area = physmap_ro("high tables", start, BYTES_TO_MAP); if (ERROR_PTR == table_area) { msg_perr("Failed getting access to coreboot high tables.\n"); return -1; |