diff options
| author | stefanct <stefanct@2b7e53f0-3cfb-0310-b3e9-8179ed1497e1> | 2014-08-05 23:28:47 +0000 |
|---|---|---|
| committer | stefanct <stefanct@2b7e53f0-3cfb-0310-b3e9-8179ed1497e1> | 2014-08-05 23:28:47 +0000 |
| commit | 353501580cf044c7645874ef6bad63bd478c81b2 (patch) | |
| tree | 89281c1e08bcc265ac38ba1f1497462f97627fbc /cli_classic.c | |
| parent | d851a29d2b7548a7fdc26c012cad6d20c31a5737 (diff) | |
| download | flashrom-353501580cf044c7645874ef6bad63bd478c81b2.tar.gz | |
ichspi: fix missing set_addr on erases and possible crossings of 256 B boundaries.
Apparently the erase function did never set any address before issuing the
erase commands. How could this ever work?
Also, according to PCH documentation crossing 256 byte boundaries is invalid
and may cause wraparound due to the flash chip's pages. Check for this on
reads as well as writes.
Thanks to Vladimir 'φ-coder/phcoder' Serbinenko for noticing these issues
and providing the initial patch.
Signed-off-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Acked-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
git-svn-id: https://code.coreboot.org/svn/flashrom/trunk@1837 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'cli_classic.c')
0 files changed, 0 insertions, 0 deletions