diff options
| author | mkarcher <mkarcher@2b7e53f0-3cfb-0310-b3e9-8179ed1497e1> | 2010-01-12 15:36:24 +0000 |
|---|---|---|
| committer | mkarcher <mkarcher@2b7e53f0-3cfb-0310-b3e9-8179ed1497e1> | 2010-01-12 15:36:24 +0000 |
| commit | 97839cf57726d20153b4a8009d112e48079834cd (patch) | |
| tree | 0de6c940c2288444810f571fabe0687c7e1ba40a /cli_classic.c | |
| parent | 066fe6553bea25e06566b79472524d02dbfdf373 (diff) | |
| download | flashrom-97839cf57726d20153b4a8009d112e48079834cd.tar.gz | |
Enable -Wshadow, clean code for that
This is not just for fun. We hit a real bug on BSD with the outl macros.
The macro variable tmp collided with the tmp from outer scope.
second revision, now also taking care of inb/inw/inl. While that shadowing
did not introduce bugs (yet), of course it breaks the build on BSD when
-Wshadow is enabled.
Signed-off-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>
Acked-by: Luc Verhaegen <libv@skynet.be>
git-svn-id: https://code.coreboot.org/svn/flashrom/trunk@860 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'cli_classic.c')
| -rw-r--r-- | cli_classic.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/cli_classic.c b/cli_classic.c index d3e7a15..6cb0578 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -150,7 +150,6 @@ int cli_classic(int argc, char *argv[]) if (argc > 1) { /* Yes, print them. */ - int i; printf_debug("The arguments are:\n"); for (i = 1; i < argc; ++i) printf_debug("%s\n", argv[i]); |