diff options
author | hailfinger <hailfinger@2b7e53f0-3cfb-0310-b3e9-8179ed1497e1> | 2011-08-15 19:54:20 +0000 |
---|---|---|
committer | hailfinger <hailfinger@2b7e53f0-3cfb-0310-b3e9-8179ed1497e1> | 2011-08-15 19:54:20 +0000 |
commit | 6fd69f0c25c1fdd855af93c073e886d56c01a31b (patch) | |
tree | ce63847ee6cc1e63289e3f658a5d57ebd35b3619 /dediprog.c | |
parent | 5e88d071c691206c3da74b4e9ebf1559069fc4cf (diff) | |
download | flashrom-6fd69f0c25c1fdd855af93c073e886d56c01a31b.tar.gz |
Fixup of r1397:
- Mixing uninitialized and initialized local variables leads to
confusion.
- ft2232_spi error cases should have gotten some error handling, and
that's the reason the curly braces were there.
- Fixing typos/wording in some places would have been nice given that
those places were touched anyway.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Stefan Tauner <stefan.tauner@student.tuwien.ac.at>
git-svn-id: https://code.coreboot.org/svn/flashrom/trunk@1413 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'dediprog.c')
-rw-r--r-- | dediprog.c | 6 |
1 files changed, 4 insertions, 2 deletions
@@ -496,7 +496,8 @@ static int dediprog_command_f(int timeout) static int parse_voltage(char *voltage) { char *tmp = NULL; - int i, millivolt, fraction = 0; + int i; + int millivolt = 0, fraction = 0; if (!voltage || !strlen(voltage)) { msg_perr("Empty voltage= specified.\n"); @@ -574,7 +575,8 @@ int dediprog_init(void) { struct usb_device *dev; char *voltage; - int millivolt = 3500, ret; + int millivolt = 3500; + int ret; msg_pspew("%s\n", __func__); |