summaryrefslogtreecommitdiff
path: root/drkaiser.c
diff options
context:
space:
mode:
authorhailfinger <hailfinger@2b7e53f0-3cfb-0310-b3e9-8179ed1497e1>2010-07-03 11:02:10 +0000
committerhailfinger <hailfinger@2b7e53f0-3cfb-0310-b3e9-8179ed1497e1>2010-07-03 11:02:10 +0000
commitd8b5e85a47b538c11a47c2962fe36729be1c8a6c (patch)
tree46568cf766d19740418be5ca8eaa494c7e69cc36 /drkaiser.c
parentd00169f414c410e9ef47f18b501fd35507432e74 (diff)
downloadflashrom-d8b5e85a47b538c11a47c2962fe36729be1c8a6c.tar.gz
Kill global variables, constants and functions if local scope suffices.
Constify variables where possible. Initialize programmer-related variables explicitly in programmer_init to allow running programmer_init from a clean state after programmer_shutdown. Prohibit registering programmer shutdown functions before init or after shutdown. Kill some dead code. Rename global variables with namespace-polluting names. Use a previously unused locking helper function in sst49lfxxxc.c. This is needed for libflashrom. Effects on the binary size of flashrom are minimal (300 bytes shrinkage), but the data section shrinks by 4384 bytes, and that's a good thing if flashrom is operating in constrained envionments. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de> git-svn-id: https://code.coreboot.org/svn/flashrom/trunk@1068 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'drkaiser.c')
-rw-r--r--drkaiser.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drkaiser.c b/drkaiser.c
index f1078cb..3bbff7c 100644
--- a/drkaiser.c
+++ b/drkaiser.c
@@ -26,12 +26,12 @@
#define PCI_MAGIC_DRKAISER_ADDR 0x50
#define PCI_MAGIC_DRKAISER_VALUE 0xa971
-struct pcidev_status drkaiser_pcidev[] = {
+const struct pcidev_status drkaiser_pcidev[] = {
{0x1803, 0x5057, OK, "Dr. Kaiser", "PC-Waechter (Actel FPGA)"},
{},
};
-uint8_t *drkaiser_bar;
+static uint8_t *drkaiser_bar;
int drkaiser_init(void)
{