diff options
| author | hailfinger <hailfinger@2b7e53f0-3cfb-0310-b3e9-8179ed1497e1> | 2008-05-14 12:03:06 +0000 |
|---|---|---|
| committer | hailfinger <hailfinger@2b7e53f0-3cfb-0310-b3e9-8179ed1497e1> | 2008-05-14 12:03:06 +0000 |
| commit | 775f026230f37f9cea309bd5e4efe2764085d796 (patch) | |
| tree | 96e3402473e7630b467b7befe97e0a03ecdc21f4 /jedec.c | |
| parent | 18a09fed550f68927ce00fd64d9b93750b2a8bff (diff) | |
| download | flashrom-775f026230f37f9cea309bd5e4efe2764085d796.tar.gz | |
Original v2 revision: 3308
Check the JEDEC vendor ID for correct parity. Flash chips which can be
detected by JEDEC probe routines all have vendor IDs with correct
parity. Use a parity check as additional hint whether a vendor ID makes
sense.
Note: Device IDs have no parity requirements whatsoever.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Peter Stuge <peter@stuge.se>
git-svn-id: https://code.coreboot.org/svn/flashrom/trunk@231 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'jedec.c')
| -rw-r--r-- | jedec.c | 13 |
1 files changed, 12 insertions, 1 deletions
@@ -27,6 +27,14 @@ #define MAX_REFLASH_TRIES 0x10 +/* Check one byte for odd parity */ +uint8_t oddparity(uint8_t val) +{ + val = (val ^ (val >> 4)) & 0xf; + val = (val ^ (val >> 2)) & 0x3; + return (val ^ (val >> 1)) & 0x1; +} + void toggle_ready_jedec(volatile uint8_t *dst) { unsigned int i = 0; @@ -123,7 +131,10 @@ int probe_jedec(struct flashchip *flash) *(volatile uint8_t *)(bios + 0x5555) = 0xF0; myusec_delay(40); - printf_debug("%s: id1 0x%x, id2 0x%x\n", __FUNCTION__, largeid1, largeid2); + printf_debug("%s: id1 0x%x, id2 0x%x", __FUNCTION__, largeid1, largeid2); + if (!oddparity(id1)) + printf_debug(", id1 parity violation"); + printf_debug("\n"); if (largeid1 == flash->manufacture_id && largeid2 == flash->model_id) return 1; |