diff options
author | hailfinger <hailfinger@2b7e53f0-3cfb-0310-b3e9-8179ed1497e1> | 2009-06-13 12:04:03 +0000 |
---|---|---|
committer | hailfinger <hailfinger@2b7e53f0-3cfb-0310-b3e9-8179ed1497e1> | 2009-06-13 12:04:03 +0000 |
commit | 25a91cb722f15b985a18a3155543c8909133e969 (patch) | |
tree | 66c9108eda2f0f7129f2ba55b9cb757414d9466a /sb600spi.c | |
parent | f060283ec7e2c03cfd4024ec9c291f9b6306564b (diff) | |
download | flashrom-25a91cb722f15b985a18a3155543c8909133e969.tar.gz |
Every SPI host controller implemented its own way to read flash chips.
This was partly due to a design problem in the abstraction layer.
There should be exactly two different functions for reading SPI chips:
- memory mapped reads
- SPI command reads.
Each of them should be contained in a separate function, optionally
taking parameters where needed.
This patch solves the problems mentioned above, shortens the code and
makes the code logic a lot more obvious.
Since open-coding the min() function leads to errors, include it in this
patch as well.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Ronald G. Minnich <rminnich@gmail.com>
git-svn-id: https://code.coreboot.org/svn/flashrom/trunk@589 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'sb600spi.c')
-rw-r--r-- | sb600spi.c | 10 |
1 files changed, 2 insertions, 8 deletions
@@ -41,14 +41,8 @@ uint8_t *sb600_spibar; int sb600_spi_read(struct flashchip *flash, uint8_t *buf) { - int rc = 0, i; - int total_size = flash->total_size * 1024; - int page_size = 8; - - for (i = 0; i < total_size / page_size; i++) - spi_nbyte_read(i * page_size, (void *)(buf + i * page_size), - page_size); - return rc; + /* Maximum read length is 8 bytes. */ + return spi_read_chunked(flash, buf, 8); } uint8_t sb600_read_status_register(void) |