diff options
| author | hailfinger <hailfinger@2b7e53f0-3cfb-0310-b3e9-8179ed1497e1> | 2009-05-16 21:22:56 +0000 |
|---|---|---|
| committer | hailfinger <hailfinger@2b7e53f0-3cfb-0310-b3e9-8179ed1497e1> | 2009-05-16 21:22:56 +0000 |
| commit | 676fec9b1d0df41ec69e87bc8e9f0c1605f5a577 (patch) | |
| tree | a505b6f813fc4f7601f77e7195e479dfddc73571 /sharplhf00l04.c | |
| parent | 2a97d2afd35986c5c5208c4b6f58eab11cbaf3ec (diff) | |
| download | flashrom-676fec9b1d0df41ec69e87bc8e9f0c1605f5a577.tar.gz | |
Use chipaddr instead of volatile uint8_t * because when we access
chips in external flashers, they are not accessed via pointers at all.
Benefits:
This allows us to differentiate between volatile machine memory accesses
and flash chip accesses.
It also enforces usage of chip_{read,write}[bwl] to access flash chips,
so nobody will unintentionally use pointers to access chips anymore.
Some unneeded casts are removed as well.
Grepping for chip operations and machine memory operations doesn't yield
any false positives anymore.
Compile tested on 32 bit and 64 bit Linux.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
git-svn-id: https://code.coreboot.org/svn/flashrom/trunk@519 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Diffstat (limited to 'sharplhf00l04.c')
| -rw-r--r-- | sharplhf00l04.c | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/sharplhf00l04.c b/sharplhf00l04.c index 52071e6..c59203d 100644 --- a/sharplhf00l04.c +++ b/sharplhf00l04.c @@ -36,7 +36,7 @@ void print_lhf00l04_status(uint8_t status) int probe_lhf00l04(struct flashchip *flash) { - volatile uint8_t *bios = flash->virtual_memory; + chipaddr bios = flash->virtual_memory; uint8_t id1, id2; #if 0 @@ -71,7 +71,7 @@ int probe_lhf00l04(struct flashchip *flash) return 1; } -uint8_t wait_lhf00l04(volatile uint8_t *bios) +uint8_t wait_lhf00l04(chipaddr bios) { uint8_t status; uint8_t id1, id2; @@ -101,17 +101,17 @@ uint8_t wait_lhf00l04(volatile uint8_t *bios) int erase_lhf00l04_block(struct flashchip *flash, int offset) { - volatile uint8_t *bios = flash->virtual_memory + offset; - volatile uint8_t *wrprotect = flash->virtual_registers + offset + 2; + chipaddr bios = flash->virtual_memory + offset; + chipaddr wrprotect = flash->virtual_registers + offset + 2; uint8_t status; // clear status register chip_writeb(0x50, bios); - printf("Erase at %p\n", bios); + printf("Erase at 0x%lx\n", bios); status = wait_lhf00l04(flash->virtual_memory); print_lhf00l04_status(status); // clear write protect - printf("write protect is at %p\n", (wrprotect)); + printf("write protect is at 0x%lx\n", (wrprotect)); printf("write protect is 0x%x\n", chip_readb(wrprotect)); chip_writeb(0, wrprotect); printf("write protect is 0x%x\n", chip_readb(wrprotect)); @@ -142,8 +142,8 @@ int erase_lhf00l04(struct flashchip *flash) return 0; } -void write_page_lhf00l04(volatile uint8_t *bios, uint8_t *src, - volatile uint8_t *dst, int page_size) +void write_page_lhf00l04(chipaddr bios, uint8_t *src, + chipaddr dst, int page_size) { int i; @@ -160,7 +160,7 @@ int write_lhf00l04(struct flashchip *flash, uint8_t *buf) int i; int total_size = flash->total_size * 1024; int page_size = flash->page_size; - volatile uint8_t *bios = flash->virtual_memory; + chipaddr bios = flash->virtual_memory; erase_lhf00l04(flash); if (chip_readb(bios) != 0xff) { |