diff options
author | Jan Hubicka <hubicka@ucw.cz> | 2014-12-15 07:19:51 +0100 |
---|---|---|
committer | Jan Hubicka <hubicka@gcc.gnu.org> | 2014-12-15 06:19:51 +0000 |
commit | dea91a66ff51bb0f37db48baebc7e098947713e9 (patch) | |
tree | 7d0f222bbf1aafe6ff3d8426db8aafe30396b616 /gcc/ipa.c | |
parent | f1ced6f5e7e78a6818c4820c4a5f103b74112f93 (diff) | |
download | gcc-dea91a66ff51bb0f37db48baebc7e098947713e9.tar.gz |
re PR ipa/61602 (ICE in lto1 on x86_64-linux-gnu in ipa_single_use, at ipa.c:1257)
PR ipa/61602
* gcc.dg/torture/pr61602.c: New testcase.
* cgraph.h (ipa_discover_readonly_nonaddressable_vars): Return bool.
* ipa.c (set_writeonly_bit): Track if reference was removed.
(ipa_discover_readonly_nonaddressable_vars): Return true if any
references was removed.
* ipa-reference.c (propagate): Return TODO_remove_functions if
reference was removed.
From-SVN: r218731
Diffstat (limited to 'gcc/ipa.c')
-rw-r--r-- | gcc/ipa.c | 23 |
1 files changed, 17 insertions, 6 deletions
diff --git a/gcc/ipa.c b/gcc/ipa.c index ec19d5d8fa6..d7ec4978533 100644 --- a/gcc/ipa.c +++ b/gcc/ipa.c @@ -714,14 +714,18 @@ set_readonly_bit (varpool_node *vnode, void *data ATTRIBUTE_UNUSED) /* Set writeonly bit and clear the initalizer, since it will not be needed. */ bool -set_writeonly_bit (varpool_node *vnode, void *data ATTRIBUTE_UNUSED) +set_writeonly_bit (varpool_node *vnode, void *data) { vnode->writeonly = true; if (optimize) { DECL_INITIAL (vnode->decl) = NULL; if (!vnode->alias) - vnode->remove_all_references (); + { + if (vnode->num_references ()) + *(bool *)data = true; + vnode->remove_all_references (); + } } return false; } @@ -739,15 +743,18 @@ clear_addressable_bit (varpool_node *vnode, void *data ATTRIBUTE_UNUSED) /* Discover variables that have no longer address taken or that are read only and update their flags. + Return true when unreachable symbol removan should be done. + FIXME: This can not be done in between gimplify and omp_expand since readonly flag plays role on what is shared and what is not. Currently we do this transformation as part of whole program visibility and re-do at ipa-reference pass (to take into account clonning), but it would make sense to do it before early optimizations. */ -void +bool ipa_discover_readonly_nonaddressable_vars (void) { + bool remove_p = false; varpool_node *vnode; if (dump_file) fprintf (dump_file, "Clearing variable flags:"); @@ -762,14 +769,16 @@ ipa_discover_readonly_nonaddressable_vars (void) bool read = false; bool explicit_refs = true; - process_references (vnode, &written, &address_taken, &read, &explicit_refs); + process_references (vnode, &written, &address_taken, &read, + &explicit_refs); if (!explicit_refs) continue; if (!address_taken) { if (TREE_ADDRESSABLE (vnode->decl) && dump_file) fprintf (dump_file, " %s (non-addressable)", vnode->name ()); - vnode->call_for_node_and_aliases (clear_addressable_bit, NULL, true); + vnode->call_for_node_and_aliases (clear_addressable_bit, NULL, + true); } if (!address_taken && !written /* Making variable in explicit section readonly can cause section @@ -785,11 +794,13 @@ ipa_discover_readonly_nonaddressable_vars (void) { if (dump_file) fprintf (dump_file, " %s (write-only)", vnode->name ()); - vnode->call_for_node_and_aliases (set_writeonly_bit, NULL, true); + vnode->call_for_node_and_aliases (set_writeonly_bit, &remove_p, + true); } } if (dump_file) fprintf (dump_file, "\n"); + return remove_p; } /* Free inline summary. */ |