diff options
author | Bill Schmidt <wschmidt@linux.ibm.com> | 2022-02-02 21:30:27 -0600 |
---|---|---|
committer | Bill Schmidt <wschmidt@linux.ibm.com> | 2022-02-03 11:17:36 -0600 |
commit | 48bd780ee327c9ae6ffc0641e73cc1f4939fb204 (patch) | |
tree | 57734c18b2b615a7d2fd7f277cf184b69fb58d7d /gcc/testsuite/gcc.target/powerpc/pr86731-nogimplefold-longlong.c | |
parent | 3f30f2d1dbb3228b8468b26239fe60c2974ce2ac (diff) | |
download | gcc-48bd780ee327c9ae6ffc0641e73cc1f4939fb204.tar.gz |
rs6000: Remove -m[no-]fold-gimple flag [PR103686]
The -m[no-]fold-gimple flag was really intended primarily for internal
testing while implementing GIMPLE folding for rs6000 vector built-in
functions. It ended up leaking into other places, causing problems such
as PR103686 identifies. Let's remove it.
There are a number of tests in the testsuite that require adjustment.
Some specify -mfold-gimple directly, which is the default, so that is
handled by removing the option. Others unnecessarily specify
-mno-fold-gimple, as the tests work fine without this. Again that is
handled by removing the option. There are a couple of extra variants of
tests specifically for -mno-fold-gimple; for those, we can just remove the
whole test.
gcc.target/powerpc/builtins-1.c was more problematic. It was written in
such a way as to be extremely fragile. For this one, I rewrote the whole
test in a different style, using individual functions to test each
built-in function. These same tests are also largely covered by
builtins-1-be-folded.c and builtins-1-le-folded.c, so I chose to
explicitly make this test -mbig for simplicity, and use -O2 for clean code
generation. I made some slight modifications to the expected instruction
counts as a result, and tested on both 32- and 64-bit.
2022-02-02 Bill Schmidt <wschmidt@linux.ibm.com>
gcc/
PR target/103686
* config/rs6000/rs6000-builtin.cc (rs6000_gimple_fold_builtin): Remove
test for !rs6000_fold_gimple.
* config/rs6000/rs6000.cc (rs6000_option_override_internal): Likewise.
* config/rs6000/rs6000.opt (mfold-gimple): Remove.
gcc/testsuite/
PR target/103686
* gcc.target/powerpc/builtins-1-be-folded.c: Remove -mfold-gimple
option.
* gcc.target/powerpc/builtins-1-le-folded.c: Likewise.
* gcc.target/powerpc/builtins-1.c: Rewrite to use small functions and
restrict to -O2 -mbig for predictability. Adjust instruction counts.
* gcc.target/powerpc/builtins-5.c: Remove -mno-fold-gimple option.
* gcc.target/powerpc/p8-vec-xl-xst.c: Likewise.
* gcc.target/powerpc/pr83926.c: Likewise.
* gcc.target/powerpc/pr86731-nogimplefold-longlong.c: Delete.
* gcc.target/powerpc/pr86731-nogimplefold.c: Delete.
* gcc.target/powerpc/swaps-p8-17.c: Remove -mno-fold-gimple option.
Diffstat (limited to 'gcc/testsuite/gcc.target/powerpc/pr86731-nogimplefold-longlong.c')
-rw-r--r-- | gcc/testsuite/gcc.target/powerpc/pr86731-nogimplefold-longlong.c | 32 |
1 files changed, 0 insertions, 32 deletions
diff --git a/gcc/testsuite/gcc.target/powerpc/pr86731-nogimplefold-longlong.c b/gcc/testsuite/gcc.target/powerpc/pr86731-nogimplefold-longlong.c deleted file mode 100644 index 2c463120676..00000000000 --- a/gcc/testsuite/gcc.target/powerpc/pr86731-nogimplefold-longlong.c +++ /dev/null @@ -1,32 +0,0 @@ -/* PR86731. Verify that the rs6000 gimple-folding code handles the - left shift operation properly. This is a testcase variation that - explicitly disables gimple folding. */ - -/* { dg-do compile } */ -/* { dg-require-effective-target powerpc_p8vector_ok } */ -/* { dg-require-effective-target lp64 } */ -/* { dg-options "-maltivec -O3 -fwrapv -mno-fold-gimple -mpower8-vector " } */ -/* { dg-prune-output "gimple folding of rs6000 builtins has been disabled." } */ - - -#include <altivec.h> - -vector unsigned long long splatu4(void) -{ - vector unsigned long long mzero = {-1,-1}; - return (vector unsigned long long) vec_sl(mzero, mzero); -} - -vector signed long long splats4(void) -{ - vector unsigned long long mzero = {-1,-1}; - return (vector signed long long) vec_sl(mzero, mzero); -} - -/* Codegen will consist of splat and shift instructions for most types. - Noted variations: if gimple folding is disabled, or if -fwrapv is not specified, the - long long tests will generate a vspltisw+vsld pair, versus generating a lvx. */ -/* { dg-final { scan-assembler-times {\mvspltis[bhw]\M|\mxxspltib\M} 2 } } */ -/* { dg-final { scan-assembler-times {\mvsl[bhwd]\M} 2 } } */ -/* { dg-final { scan-assembler-times {\mlvx\M} 0 } } */ - |