summaryrefslogtreecommitdiff
path: root/libcpp
diff options
context:
space:
mode:
authorRoger Sayle <roger@nextmovesoftware.com>2023-04-30 23:47:13 +0100
committerRoger Sayle <roger@nextmovesoftware.com>2023-04-30 23:47:13 +0100
commitb159026b739f46e6d552bb23e8f51f03e291f51e (patch)
treefc6a3bfba4695d28662e6ce2e720aa382b856d83 /libcpp
parentd56af02fb1fd6eb50beb8a1689cf646bc567dbfc (diff)
downloadgcc-b159026b739f46e6d552bb23e8f51f03e291f51e.tar.gz
[Committed] Update xstormy16's neghi2 pattern to not clobber the carry flag.
When I converted xstormy's neghi2 pattern from a define_expand to a define_insn, I forgot that define_expand implicitly produces a sequence of instructions, but a define_insn is an implicit parallel, thereby messing up the clobber (reg:BI CARRY_REG), which can then cause an ICE in the auto-generated added_clobbers_hard_reg_p. Whilst stripping the superfluous PARALLEL resolves this issue, an even better fix is to use xstormy16's INC instruction, that (like NOT) doesn't affect the carry flag, resulting in a neghi2 implementation that can more easily be CSE'd and scheduled. Many thanks (again) to Jeff Law for testing/reporting this issue. 2024-04-30 Roger Sayle <roger@nextmovesoftware.com> gcc/ChangeLog * config/stormy16/stormy16.md (neghi2): Rewrite pattern using inc to avoid clobbering the carry flag. gcc/testsuite/ChangeLog * gcc.target/xstormy16/neghi2.c: Update expected implementation.
Diffstat (limited to 'libcpp')
0 files changed, 0 insertions, 0 deletions