summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoel Brobecker <brobecker@gnat.com>2013-05-10 13:25:28 +0000
committerJoel Brobecker <brobecker@gnat.com>2013-05-10 13:25:28 +0000
commit4ab6caae50b7dd03fdd35f9b63f74323098d1d1a (patch)
tree093af21479faf3f3517e7443dcb4565cb60588e4
parent7698b6278eabefc34834cd51a04f8c821d6daed4 (diff)
downloadgdb-4ab6caae50b7dd03fdd35f9b63f74323098d1d1a.tar.gz
Remove FIXME in solib-aix.c:solib_aix_relocate_section_addresses
This issue should now be fixed thanks to a change in bfd removing the SEC_ALLOC flag from all sections that do not get mapped to memory. gdb/ChangeLog: * solib-aix.c (solib_aix_relocate_section_addresses): Remove FIXME comment.
-rw-r--r--gdb/ChangeLog5
-rw-r--r--gdb/solib-aix.c10
2 files changed, 5 insertions, 10 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 9f7b97228da..f7b27f58b44 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -6,6 +6,11 @@
2013-05-10 Joel Brobecker <brobecker@adacore.com>
+ * solib-aix.c (solib_aix_relocate_section_addresses):
+ Remove FIXME comment.
+
+2013-05-10 Joel Brobecker <brobecker@adacore.com>
+
PR tdep/15420:
* sol-thread.c (ps_lgetxregsize, ps_lgetxregs, ps_lsetxregs):
New functions, directly copied from sparc-sol-thread.c.
diff --git a/gdb/solib-aix.c b/gdb/solib-aix.c
index 4672b588ce3..5d15e7045af 100644
--- a/gdb/solib-aix.c
+++ b/gdb/solib-aix.c
@@ -432,16 +432,6 @@ solib_aix_relocate_section_addresses (struct so_list *so,
else
{
/* All other sections should not be relocated. */
- /* FIXME: GDB complains that the .loader section sometimes
- overlaps with other sections (Eg: the .data section).
- As far as I can tell, the loader section had the LOAD flag
- set, but not the RELOC. So it should not be relocated.
- There seems to be a problem there, and maybe it has to do
- with setting sec->addr to 0 (when the vma is indeed 0).
- But even if there wasn't, the problem then becomes the fact
- that many shared objects inside shared libraries have
- a .loader section whose vma is 0, thus also triggering
- an overlap warning. */
sec->addr = bfd_section_vma (abfd, bfd_sect);
sec->endaddr = sec->addr + bfd_section_size (abfd, bfd_sect);
}