summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Modra <amodra@bigpond.net.au>2008-10-09 01:04:30 +0000
committerAlan Modra <amodra@bigpond.net.au>2008-10-09 01:04:30 +0000
commitab5050b9c42db8047daaa2a6b7e438e695009b0c (patch)
tree3a9c3e39d0df197af27d3cabf7de0f12506215cb
parent6b2587856aa2993dd577bc52e2ef2683527a5d48 (diff)
downloadgdb-ab5050b9c42db8047daaa2a6b7e438e695009b0c.tar.gz
* elf64-ppc.c (ppc64_elf_get_synthetic_symtab): Don't attempt to
read plt relocs if no dynamic syms.
-rw-r--r--bfd/ChangeLog5
-rw-r--r--bfd/elf64-ppc.c28
2 files changed, 19 insertions, 14 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index d434e7f0c09..b2b16d0aecd 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2008-10-09 Alan Modra <amodra@bigpond.net.au>
+
+ * elf64-ppc.c (ppc64_elf_get_synthetic_symtab): Don't attempt to
+ read plt relocs if no dynamic syms.
+
2008-10-08 Alan Modra <amodra@bigpond.net.au>
* elf.c (assign_file_positions_for_load_sections): When checking
diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c
index 86fe3c3de84..523d1374a7f 100644
--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -3005,8 +3005,8 @@ ppc64_elf_get_synthetic_symtab (bfd *abfd,
}
/* Get start of .glink stubs from DT_PPC64_GLINK. */
- dynamic = bfd_get_section_by_name (abfd, ".dynamic");
- if (dynamic != NULL)
+ if (dyn_count != 0
+ && (dynamic = bfd_get_section_by_name (abfd, ".dynamic")) != NULL)
{
bfd_byte *dynbuf, *extdyn, *extdynend;
size_t extdynsize;
@@ -3061,21 +3061,21 @@ ppc64_elf_get_synthetic_symtab (bfd *abfd,
if (resolv_vma)
size += sizeof (asymbol) + sizeof ("__glink_PLTresolve");
- }
- relplt = bfd_get_section_by_name (abfd, ".rela.plt");
- if (glink != NULL && relplt != NULL)
- {
- slurp_relocs = get_elf_backend_data (abfd)->s->slurp_reloc_table;
- if (! (*slurp_relocs) (abfd, relplt, dyn_syms, TRUE))
- goto free_contents_and_exit;
+ relplt = bfd_get_section_by_name (abfd, ".rela.plt");
+ if (relplt != NULL)
+ {
+ slurp_relocs = get_elf_backend_data (abfd)->s->slurp_reloc_table;
+ if (! (*slurp_relocs) (abfd, relplt, dyn_syms, TRUE))
+ goto free_contents_and_exit;
- plt_count = relplt->size / sizeof (Elf64_External_Rela);
- size += plt_count * sizeof (asymbol);
+ plt_count = relplt->size / sizeof (Elf64_External_Rela);
+ size += plt_count * sizeof (asymbol);
- p = relplt->relocation;
- for (i = 0; i < plt_count; i++, p++)
- size += strlen ((*p->sym_ptr_ptr)->name) + sizeof ("@plt");
+ p = relplt->relocation;
+ for (i = 0; i < plt_count; i++, p++)
+ size += strlen ((*p->sym_ptr_ptr)->name) + sizeof ("@plt");
+ }
}
s = *ret = bfd_malloc (size);