more add_target removals

This removes a few more erroneous calls to add_target.  These calls
end up installing the target in a user-visible way; but these targets
are all auto-activated and, I think, should never be explicitly
requested.

I have no way to test these.

	* aix-thread.c (_initialize_aix_thread): Use
	complete_target_initialization.
	* bsd-uthread.c (_initialize_bsd_uthread): Use
	complete_target_initialization.
	* dec-thread.c (_initialize_dec_thread): Use
	complete_target_initialization.
	* ravenscar-thread.c (_initialize_ravenscar): Use
	complete_target_initialization.
	* sol-thread.c (_initialize_sol_thread): Use
	complete_target_initialization.
	* spu-multiarch.c (_initialize_spu_multiarch): Use
	complete_target_initialization.

7 files changed, 21 insertions, 6 deletions

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5da081f25ca..975d2c5e380 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,20 @@
 2013-08-05  Tom Tromey  <tromey@redhat.com>
 
+	* aix-thread.c (_initialize_aix_thread): Use
+	complete_target_initialization.
+	* bsd-uthread.c (_initialize_bsd_uthread): Use
+	complete_target_initialization.
+	* dec-thread.c (_initialize_dec_thread): Use
+	complete_target_initialization.
+	* ravenscar-thread.c (_initialize_ravenscar): Use
+	complete_target_initialization.
+	* sol-thread.c (_initialize_sol_thread): Use
+	complete_target_initialization.
+	* spu-multiarch.c (_initialize_spu_multiarch): Use
+	complete_target_initialization.
+
+2013-08-05  Tom Tromey  <tromey@redhat.com>
+
 	* ada-exp.y (write_var_or_type): Use bound_minimal_symbol.
 	* ada-lang.c (ada_lookup_simple_minsym): Return
 	bound_minimal_symbol.
diff --git a/gdb/aix-thread.c b/gdb/aix-thread.c
index fd1d69bc308..70f9a3e2716 100644
--- a/gdb/aix-thread.c
+++ b/gdb/aix-thread.c
@@ -1837,7 +1837,7 @@ void
 _initialize_aix_thread (void)
 {
   init_aix_thread_ops ();
-  add_target (&aix_thread_ops);
+  complete_target_initialization (&aix_thread_ops);
 
   /* Notice when object files get loaded and unloaded.  */
   observer_attach_new_objfile (new_objfile);
diff --git a/gdb/bsd-uthread.c b/gdb/bsd-uthread.c
index 6a07985a5df..0a2ea8174db 100644
--- a/gdb/bsd-uthread.c
+++ b/gdb/bsd-uthread.c
@@ -547,7 +547,7 @@ extern initialize_file_ftype _initialize_bsd_uthread;
 void
 _initialize_bsd_uthread (void)
 {
-  add_target (bsd_uthread_target ());
+  complete_target_initialization (bsd_uthread_target ());
 
   bsd_uthread_data = gdbarch_data_register_pre_init (bsd_uthread_init);
 
diff --git a/gdb/dec-thread.c b/gdb/dec-thread.c
index 27cf0047fc1..f07721d30dc 100644
--- a/gdb/dec-thread.c
+++ b/gdb/dec-thread.c
@@ -727,7 +727,7 @@ void
 _initialize_dec_thread (void)
 {
   init_dec_thread_ops ();
-  add_target (&dec_thread_ops);
+  complete_target_initialization (&dec_thread_ops);
 
   observer_attach_new_objfile (dec_thread_new_objfile_observer);
 
diff --git a/gdb/ravenscar-thread.c b/gdb/ravenscar-thread.c
index 0a3100da4ca..26b81714410 100644
--- a/gdb/ravenscar-thread.c
+++ b/gdb/ravenscar-thread.c
@@ -433,7 +433,7 @@ _initialize_ravenscar (void)
      ravenscar ops if needed.  */
   observer_attach_inferior_created (ravenscar_inferior_created);
 
-  add_target (&ravenscar_ops);
+  complete_target_initialization (&ravenscar_ops);
 
   add_prefix_cmd ("ravenscar", no_class, set_ravenscar_command,
                   _("Prefix command for changing Ravenscar-specific settings"),
diff --git a/gdb/sol-thread.c b/gdb/sol-thread.c
index f1b29a000f3..c9abaf735cf 100644
--- a/gdb/sol-thread.c
+++ b/gdb/sol-thread.c
@@ -1276,7 +1276,7 @@ _initialize_sol_thread (void)
   resolve (td_thr_getgregs);
   resolve (td_thr_setgregs);
 
-  add_target (&sol_thread_ops);
+  complete_target_initialization (&sol_thread_ops);
 
   add_cmd ("sol-threads", class_maintenance, info_solthreads,
 	   _("Show info on Solaris user threads."), &maintenanceinfolist);
diff --git a/gdb/spu-multiarch.c b/gdb/spu-multiarch.c
index a74bd30a996..e93f1428728 100644
--- a/gdb/spu-multiarch.c
+++ b/gdb/spu-multiarch.c
@@ -410,7 +410,7 @@ _initialize_spu_multiarch (void)
 {
   /* Install ourselves on the target stack.  */
   init_spu_ops ();
-  add_target (&spu_ops);
+  complete_target_initialization (&spu_ops);
 
   /* Install observers to watch for SPU objects.  */
   observer_attach_inferior_created (spu_multiarch_inferior_created);