diff options
author | Nick Clifton <nickc@redhat.com> | 2007-06-29 14:36:21 +0000 |
---|---|---|
committer | Nick Clifton <nickc@redhat.com> | 2007-06-29 14:36:21 +0000 |
commit | ac145e5278c4863ced0dc03311c7ef804b6847a4 (patch) | |
tree | 0a52cc664d4dae0e6599f75b4766f5addee18c36 | |
parent | a6419584a8ec84859a643b39c0d40136c114adda (diff) | |
download | gdb-ac145e5278c4863ced0dc03311c7ef804b6847a4.tar.gz |
* bfd.c (bfd_demangle): Plug memory leak (Coverity).
-rw-r--r-- | bfd/ChangeLog | 4 | ||||
-rw-r--r-- | bfd/bfd.c | 12 |
2 files changed, 10 insertions, 6 deletions
diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 33313c031ad..ad71032f6fa 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,7 @@ +2007-06-29 Michael Snyder <msnyder@svkmacdonelllnx> + + * bfd.c (bfd_demangle): Plug memory leak (Coverity). + 2007-06-29 M R Swami Reddy <MR.Swami.Reddy@nsc.com> * Makefile.am: Add cr16 related entry diff --git a/bfd/bfd.c b/bfd/bfd.c index b1c49aa08f4..510df0ab27f 100644 --- a/bfd/bfd.c +++ b/bfd/bfd.c @@ -1773,12 +1773,12 @@ bfd_demangle (bfd *abfd, const char *name, int options) suf = res + len; suf_len = strlen (suf) + 1; final = bfd_malloc (pre_len + len + suf_len); - if (final == NULL) - return NULL; - - memcpy (final, pre, pre_len); - memcpy (final + pre_len, res, len); - memcpy (final + pre_len + len, suf, suf_len); + if (final != NULL) + { + memcpy (final, pre, pre_len); + memcpy (final + pre_len, res, len); + memcpy (final + pre_len + len, suf, suf_len); + } free (res); res = final; } |