diff options
| author | Ulrich Weigand <uweigand@de.ibm.com> | 2010-01-04 14:56:16 +0000 |
|---|---|---|
| committer | Ulrich Weigand <uweigand@de.ibm.com> | 2010-01-04 14:56:16 +0000 |
| commit | cc36ab23f62980781b23d6058692a70e7aab5d0e (patch) | |
| tree | dafa39237bf64145e077845aeb382c77ccf24336 | |
| parent | f14722c413b4f0d0f8071e16e3c3000ec82dd772 (diff) | |
| download | gdb-cc36ab23f62980781b23d6058692a70e7aab5d0e.tar.gz | |
* dwarf2loc.c (read_pieced_value): If a piece occupies part of
a register, assume the least-signficant part is used.
(write_pieced_value): Likewise.
| -rw-r--r-- | gdb/ChangeLog | 6 | ||||
| -rw-r--r-- | gdb/dwarf2loc.c | 22 |
2 files changed, 24 insertions, 4 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a8f1278cda5..79fe93a2ee7 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,11 @@ 2010-01-04 Ulrich Weigand <uweigand@de.ibm.com> + * dwarf2loc.c (read_pieced_value): If a piece occupies part of + a register, assume the least-signficant part is used. + (write_pieced_value): Likewise. + +2010-01-04 Ulrich Weigand <uweigand@de.ibm.com> + * printcmd.c: Include "arch-utils.h". (do_one_display): Re-parse expression if current architecture changed. diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c index 726345c551a..6679d74bd3a 100644 --- a/gdb/dwarf2loc.c +++ b/gdb/dwarf2loc.c @@ -275,11 +275,17 @@ read_pieced_value (struct value *v) case DWARF_VALUE_REGISTER: { struct gdbarch *arch = get_frame_arch (frame); - bfd_byte regval[MAX_REGISTER_SIZE]; int gdb_regnum = gdbarch_dwarf2_reg_to_regnum (arch, p->v.expr.value); - get_frame_register (frame, gdb_regnum, regval); - memcpy (contents + offset, regval, p->size); + int reg_offset = 0; + + if (gdbarch_byte_order (arch) == BFD_ENDIAN_BIG + && p->size < register_size (arch, gdb_regnum)) + /* Big-endian, and we want less than full size. */ + reg_offset = register_size (arch, gdb_regnum) - p->size; + + get_frame_register_bytes (frame, gdb_regnum, reg_offset, p->size, + contents + offset); } break; @@ -346,7 +352,15 @@ write_pieced_value (struct value *to, struct value *from) { struct gdbarch *arch = get_frame_arch (frame); int gdb_regnum = gdbarch_dwarf2_reg_to_regnum (arch, p->v.expr.value); - put_frame_register (frame, gdb_regnum, contents + offset); + int reg_offset = 0; + + if (gdbarch_byte_order (arch) == BFD_ENDIAN_BIG + && p->size < register_size (arch, gdb_regnum)) + /* Big-endian, and we want less than full size. */ + reg_offset = register_size (arch, gdb_regnum) - p->size; + + put_frame_register_bytes (frame, gdb_regnum, reg_offset, p->size, + contents + offset); } break; case DWARF_VALUE_MEMORY: |