diff options
| author | Tom Tromey <tromey@redhat.com> | 2013-10-07 19:31:13 +0000 |
|---|---|---|
| committer | Tom Tromey <tromey@redhat.com> | 2013-10-07 19:31:13 +0000 |
| commit | 05348221297f63aabaab81061c81d1829b87abf5 (patch) | |
| tree | 6f5f2b4229c61297c13a505fa60c9731abab3e9b /gdb/ChangeLog | |
| parent | 097e93eccdf7d7539ff8ff2d137a791f585c3504 (diff) | |
| download | gdb-05348221297f63aabaab81061c81d1829b87abf5.tar.gz | |
don't share per-BFD data if relocations are needed
Right now we always share per-BFD data across objfiles, if there is a
BFD. This works fine. However, we're going to start sharing more
data, and sometimes this data will come directly from sections of the
BFD. If such a section has SEC_RELOC set, then the data coming from
that section will not be truly sharable -- the section will be
program-space-dependent, and re-read by gdb for each objfile.
This patch disallows per-BFD sharing in this case. This is a bit
"heavy" in that we could in theory examine each bit of shared data for
suitability. However, that is more complicated, and SEC_RELOC is rare
enough that I think we needn't bother.
Note that the "no sharing" case is equivalent to "gdb works as it
historically did". That is, the sharing is a new(-ish) optimization.
Built and regtested on x86-64 Fedora 18.
* gdb_bfd.c (struct gdb_bfd_data) <relocation_computed,
needs_relocations>: New fields.
(gdb_bfd_requires_relocations): New function.
* gdb_bfd.h (gdb_bfd_requires_relocations): Declare.
* objfiles.c (get_objfile_bfd_data): Disallow sharing if
the BFD needs relocations applied.
Diffstat (limited to 'gdb/ChangeLog')
| -rw-r--r-- | gdb/ChangeLog | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 9c3d419631c..5a10cbaa39c 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,12 @@ +2013-10-07 Tom Tromey <tromey@redhat.com> + + * gdb_bfd.c (struct gdb_bfd_data) <relocation_computed, + needs_relocations>: New fields. + (gdb_bfd_requires_relocations): New function. + * gdb_bfd.h (gdb_bfd_requires_relocations): Declare. + * objfiles.c (get_objfile_bfd_data): Disallow sharing if + the BFD needs relocations applied. + 2013-10-07 Pedro Alves <palves@redhat.com> PR breakpoints/11568 |