diff options
| author | Joel Brobecker <brobecker@gnat.com> | 2013-10-11 08:23:10 +0000 |
|---|---|---|
| committer | Joel Brobecker <brobecker@gnat.com> | 2013-10-11 08:23:10 +0000 |
| commit | 584529ca6570579ba59bc0480f302d4108d4775f (patch) | |
| tree | f0e33054a022e27007e6c2cf29f6c1f65ce26ee9 /gdb/ChangeLog | |
| parent | b3ca8048b0c43163f61daf22c9601ab95262cbe7 (diff) | |
| download | gdb-584529ca6570579ba59bc0480f302d4108d4775f.tar.gz | |
warn if "source" fails to open the file when from_tty == 0
Consider the following example:
% gdb -q -batch -ex 'source nonexistant-file'
[nothing]
One would have at least expected the debugger to warn about
not finding the file, similar to the error shown when using
a more interactive mode. Eg:
(gdb) source nonexistant-file
nonexistant-file: No such file or directory.
Not raising an error appears to be intentional, presumably in order
to prevent this situation from stoping the execution of a GDB script.
But the lack of at least a warning makes it harder for a user to
diagnose any issue, if the file was expected to be there and readable.
This patch adds a warning in that case:
% gdb -q -batch -ex 'source nonexistant-file'
warning: nonexistant-file: No such file or directory.
gdb/ChangeLog:
* utils.h (perror_warning_with_name): Add declaration.
* utils.c (perror_warning_with_name): New function.
* cli/cli-cmds.c (source_script_with_search): Add call to
perror_warning_with_name if from_tty is nul.
gdb/testsuite/ChangeLog:
* gdb.base/source-nofile.gdb: New file.
* gdb.base/source.exp: Add two tests verifying the behavior when
the "source" command is given a non-existant filename.
Diffstat (limited to 'gdb/ChangeLog')
| -rw-r--r-- | gdb/ChangeLog | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 37ad575454c..b73fd40f3fa 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,12 @@ 2013-11-11 Joel Brobecker <brobecker@adacore.com> + * utils.h (perror_warning_with_name): Add declaration. + * utils.c (perror_warning_with_name): New function. + * cli/cli-cmds.c (source_script_with_search): Add call to + perror_warning_with_name if from_tty is nul. + +2013-11-11 Joel Brobecker <brobecker@adacore.com> + * utils.c (perror_string): New function, extracted out of throw_perror_with_name. (throw_perror_with_name): Rework to use perror_string. |