diff options
| author | Pedro Alves <palves@redhat.com> | 2013-04-08 14:09:29 +0000 |
|---|---|---|
| committer | Pedro Alves <palves@redhat.com> | 2013-04-08 14:09:29 +0000 |
| commit | c924dcadcc124916a66a6be127f2497d6c344dec (patch) | |
| tree | 895cb59e4f7d678d7fca9a5a59c53d62126ec827 /gdb/breakpoint.h | |
| parent | e5aaf6c59e348c9d60da72430515331c6c5d78b5 (diff) | |
| download | gdb-c924dcadcc124916a66a6be127f2497d6c344dec.tar.gz | |
create_breapoint / explicit mode: Error out if there's garbage after the breakpoint location.
If !PARSE_CONDITION_AND_THREAD, then ARG is just the location, nothing
else. The fact that the describing comment of create_breakpoint
doesn't mention this just looks like an oversight of when extra_string
was added. "parse_condition_and_thread" has been a misnomer ever
since extra_string was added -- better rename it avoid more confusion.
This makes it "parse_arg", as that'll remain stable even if/when more
explicit parameters are added.
gdb/
2013-04-08 Pedro Alves <palves@redhat.com>
Keith Seitz <keiths@redhat.com>
* breakpoint.c (create_breakpoint): Rename
"parse_condition_and_thread" parameter to "parse_arg". Update
describing comment. If !PARSE_ARG, then error out if ARG is not
the empty string after extracting the location.
* breakpoint.h (create_breakpoint): Rename
"parse_condition_and_thread" parameter to "parse_arg".
gdb/testsuite/
2013-04-08 Pedro Alves <palves@redhat.com>
* gdb.mi/mi-break.exp (test_error): Add tests with garbage after
the location.
Diffstat (limited to 'gdb/breakpoint.h')
| -rw-r--r-- | gdb/breakpoint.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h index 68f3ed9abeb..d740625e985 100644 --- a/gdb/breakpoint.h +++ b/gdb/breakpoint.h @@ -1269,7 +1269,7 @@ enum breakpoint_create_flags extern int create_breakpoint (struct gdbarch *gdbarch, char *arg, char *cond_string, int thread, char *extra_string, - int parse_condition_and_thread, + int parse_arg, int tempflag, enum bptype wanted_type, int ignore_count, enum auto_boolean pending_break_support, |