summaryrefslogtreecommitdiff
path: root/gdb/completer.c
diff options
context:
space:
mode:
authorJan Kratochvil <jan.kratochvil@redhat.com>2008-12-22 13:19:28 +0000
committerJan Kratochvil <jan.kratochvil@redhat.com>2008-12-22 13:19:28 +0000
commit94923161f4aa9c75a27c8f56a68662cef6695713 (patch)
tree217fdc70da117746c92455999090fd7a79045b2c /gdb/completer.c
parent6d5935ce5358685aebb1f3c0717208dfe2bef69c (diff)
downloadgdb-94923161f4aa9c75a27c8f56a68662cef6695713.tar.gz
gdb/
Fix memory double-free. * completer.c (line_completion_function): Clear LIST after called xfree. gdb/testsuite/ * gdb.base/completion.exp (Completing non-existing component): New test.
Diffstat (limited to 'gdb/completer.c')
-rw-r--r--gdb/completer.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/gdb/completer.c b/gdb/completer.c
index d109140ee3e..4747a429801 100644
--- a/gdb/completer.c
+++ b/gdb/completer.c
@@ -752,8 +752,10 @@ line_completion_function (const char *text, int matches,
if (list)
{
/* Free the storage used by LIST, but not by the strings inside.
- This is because rl_complete_internal () frees the strings. */
+ This is because rl_complete_internal () frees the strings.
+ As complete_line may abort by calling `error' clear LIST now. */
xfree (list);
+ list = NULL;
}
index = 0;
list = complete_line (text, line_buffer, point);